Add an option to filter out subworkflows in specific Cromwells

[rexwangcc]

Reason

In general, we are deploying JMUI against a Cromwell instance that uses OAuth (an OIDC based AuthProxy) but does not have CromIAM. This is affected by #576 that subworkflows are showing up in the job details page.

See discussion here: https://broadinstitute.slack.com/archives/CFA6Q2QBU/p1599146973203800?thread_ts=1599145468.201200&cid=CFA6Q2QBU

Changes

Add a INCLUDE_SUBWORKFLOWS flag and set it to True by default so subworkflows are filtered out by default as well. non-CromIAM Cromwell backends that are using OAuth should set it to False.

[samanehsan]

This looks great, thanks!

[rsasch]

Nit: if the purpose of the new config option is just to not include sub-workflows in some cases, I think naming the option IS_CROMIAM is confusing (unless you anticipate other logic will need to change based on whether or not CromIAM is involved).

[rexwangcc]

Nit: if the purpose of the new config option is just to not include sub-workflows in some cases, I think naming the option IS_CROMIAM is confusing (unless you anticipate other logic will need to change based on whether or not CromIAM is involved).

@rsasch
Thanks! That is a good point, at least for now the only purpose is to filter out sub-workflows by default. Do you think renaming it to "INCLUDE_SUBWORKFLOWS" and set it to False is safe? (safe means this won't break any Terra components/logic)

[rsasch]

Thanks! That is a good point, at least for now the only purpose is to filter out sub-workflows by default. Do you think renaming it to "INCLUDE_SUBWORKFLOWS" and set it to False is safe? (safe means this won't break any Terra components/logic)

That name works for me, but I think it should be true by default since Terra shows sub-workflows on the job details page.

[rexwangcc]

Thanks! That is a good point, at least for now the only purpose is to filter out sub-workflows by default. Do you think renaming it to "INCLUDE_SUBWORKFLOWS" and set it to False is safe? (safe means this won't break any Terra components/logic)

That name works for me, but I think it should be true by default since Terra shows sub-workflows on the job details page.

Great, thanks! TIL that by default Terra shows sub-workflows on the job details page, since we prefer the opposite in daily operations 😄