[DC-698] Upgrade from workflow-dispatch to workflow-call
#170
Conversation
s-rubenstein
changed the title
workflow-dispatch to workflow-call
| description: 'environment to run test in' | ||
| required: true | ||
| options: | ||
| - staging |
There was a problem hiding this comment.
I thought this was used by the GitHub action UI to show the possible values, to see what I mean go to https://github.com/DataBiosphere/terra-data-catalog/actions/workflows/integration-tests.yml and select Run Workflow
There was a problem hiding this comment.
Choice seemed to not be an option for workflow_call - maybe I was misunderstanding the API docs though and there's another way to specify it?
| with: | ||
| workflow: Trivy | ||
| token: ${{ secrets.BROADBOT_TOKEN }} | ||
| uses: ./.github/workflows/trivy.yml |
There was a problem hiding this comment.
I think the point of running trivy as its own workflow was so that its failure didn't fail the build, because all trivy failures we've seen so far were issues with the base image and out of our control.
If it's run this way, will it fail the build?
There was a problem hiding this comment.
I think it is run as a separate workflow still.
|
Kudos, SonarCloud Quality Gate passed!
|
| on: | ||
| workflow_call: | ||
| secrets: | ||
| token: |
There was a problem hiding this comment.
If this is token, shouldn't
GITHUB_TOKEN: ${{ secrets.BROADBOT_TOKEN }}
be
GITHUB_TOKEN: ${{ secrets.token }}
No description provided.