TSPS-259 Add provenance info to PipelineRunReport in GET PipelineRun result response #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsotobroad
approved these changes
Sep 6, 2024
| @@ -50,7 +50,7 @@ public static String convertToJsonString(Object obj) throws JsonProcessingExcept | |||
| public static final String TEST_WORKSPACE_NAME = "testTerraWorkspaceName"; | |||
| public static final String TEST_WORKSPACE_STORAGE_CONTAINER_NAME = "test-bucket-name"; | |||
| public static final String TEST_WORKSPACE_GOOGLE_PROJECT = "testGoogleProject"; | |||
| public static final String TEST_WDL_METHOD_VERSION = "0.12.1"; | |||
| public static final String TEST_WDL_METHOD_VERSION = "0.1.12"; | |||
There was a problem hiding this comment.
you didnt like my fake version???
There was a problem hiding this comment.
lol it didn't match the others and there's some cross-talk in the tests
There was a problem hiding this comment.
but oops that was actually a signal that something was wrong. reverted and fixed a bug! thanks!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new required field,
pipelineRunReport, to the AsyncPipelineRunResult object that's returned when calling GET pipeline run result.pipelineRunReportcontains the following fields regardless of PipelineRun status:pipelineRunReportcontainsoutputsif the PipelineRun succeeded.Jira Ticket
https://broadworkbench.atlassian.net/jira/software/c/projects/TSPS/boards/193?selectedIssue=TSPS-259