Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine service-provided input paths #134

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

mmorgantaylor
Copy link
Collaborator

@mmorgantaylor mmorgantaylor commented Sep 23, 2024

Description

Updating the default_value for service-provided input files to match the organization we want. This includes an hg38 prefix for all, plus different intermediate "directory" files in some cases

Changes:

  • geneticMapsPath
    • old value: /plink-genetic-maps/GRCh38_fixed/
    • new value: /hg38/plink-genetic-maps/
  • refDict
    • old value: /hg38/Homo_sapiens_assembly38.dict
    • new value: /hg38/ref_dict/Homo_sapiens_assembly38.dict
  • referencePanelPathPrefix
    • old value: /hg38/1000G_HGDP_no_singletons_ref_panel/hgdp.tgp.gwaspy.merged.merged.AN_added.bcf.ac2
    • new value: /hg38/ref_panels/1000G_HGDP_no_singletons/hgdp.tgp.gwaspy.merged.merged.AN_added.bcf.ac2

Also performed the copy of these files in the dev bucket:

✗ gcloud storage ls gs://fc-secure-10efd4d7-392a-4e9e-89ea-d6629fbb06cc/hg38/plink-genetic-maps/ | wc -l
      22

✗ gcloud storage ls gs://fc-secure-10efd4d7-392a-4e9e-89ea-d6629fbb06cc/hg38/ref_dict/Homo_sapiens_assembly38.dict
gs://fc-secure-10efd4d7-392a-4e9e-89ea-d6629fbb06cc/hg38/ref_dict/Homo_sapiens_assembly38.dict

✗ gcloud storage ls gs://fc-secure-10efd4d7-392a-4e9e-89ea-d6629fbb06cc/hg38/ref_panels/1000G_HGDP_no_singletons/ | wc -l
      66

✗ gcloud storage ls gs://fc-secure-10efd4d7-392a-4e9e-89ea-d6629fbb06cc/hg38/ref_panels/simulated/500k/ | wc -l
     110

✗ gcloud storage ls gs://fc-secure-10efd4d7-392a-4e9e-89ea-d6629fbb06cc/hg38/ref_panels/simulated/10k/ | wc -l
     110

Will need to delete the old copies once the currently running workflows using the old paths have completed.

Jira Ticket

none

Copy link
Collaborator

@jsotobroad jsotobroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes - one small TOL

# update geneticMapsPath default_value from /plink-genetic-maps/GRCh38_fixed/
- update:
tableName: pipeline_input_definitions
where: id=3 AND name='geneticMapsPath'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a slightly better approach would be to do something like where pipeline_id=3 and probably the best approach would be where pipeline_id = (select id from pipelines where name = "imputation_beagle") or w/e the equivalent for liquidbase is. No need for changes though

Copy link

sonarcloud bot commented Sep 23, 2024

@mmorgantaylor mmorgantaylor merged commit 1fc62fd into main Sep 23, 2024
12 checks passed
@mmorgantaylor mmorgantaylor deleted the update_input_paths branch September 23, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants