[TSPS-322] make explicit storage container url in PrepareImputationInputsStep #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorgantaylor
changed the title
jsotobroad
reviewed
Sep 24, 2024
|
|
||
| private final PipelineInputsRepository pipelineInputsRepository; | ||
| private final PipelineOutputsRepository pipelineOutputsRepository; | ||
| private final ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
so i think we want to autowire this in so we can use the one from the bean we create as opposed to the default one (we should do this everywhere we dont already do this)
There was a problem hiding this comment.
ah thanks, forgot about that
| @@ -8,6 +8,8 @@ public abstract class RunImputationJobFlightMapKeys { | |||
| public static final String ALL_PIPELINE_INPUTS = "all_pipeline_inputs"; | |||
| public static final String CONTROL_WORKSPACE_STORAGE_CONTAINER_NAME = | |||
| "control_workspace_storage_container_name"; | |||
| public static final String CONTROL_WORKSPACE_STORAGE_CONTAINER_PROTOCOL = | |||
| "control_workspace_storage_container_protocol"; | |||
There was a problem hiding this comment.
i wonder what the limit of these strings are in the stairway database hahaha
There was a problem hiding this comment.
haha yeah we apparently haven't hit the limit yet. want me to find out?
|
jsotobroad
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous conversion from storageContainerUrl to storageContainerName caused a problem in PreparePipelineInputsStep since it expects that value to be the full Url. Here we add a value to the flight working map to specify the protocol to append to the storageContainerName.
Also did a refactor of a bunch of methods related to input and output formatting and generation into a new PipelineInputsOutputsService.
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-332