Avoid concurrent modification in cluster scaler tests (#4600)

This will fix #4599 by making the mock leader thread safe.
DataBiosphere · Sep 29, 2023 · f1055a3 · f1055a3
1 parent 7650597
commit f1055a3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/toil/test/provisioners/clusterScalerTest.py b/src/toil/test/provisioners/clusterScalerTest.py
@@ -873,7 +873,9 @@ def getNumberOfJobsIssued(self, preemptible=None):
             return self.jobQueue.qsize()
 
     def getJobs(self):
-        return self.jobBatchSystemIDToIssuedJob.values()
+        # jobBatchSystemIDToIssuedJob may be modified while we are working.
+        # So copy it.
+        return dict(self.jobBatchSystemIDToIssuedJob).values()
 
     # AbstractScalableBatchSystem functionality
     def getNodes(self, preemptible: Optional[bool] = False, timeout: int = 600):