-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes job owner name #2872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty much exactly what I want.
We're relying on the user not to give us a too-long/uppercase/otherwise prohibited TOIL_KUBERNETES_OWNER
, but I think that's fine.
I'm going to slightly tweak the documentation, though.
The Python 2 integration tests are failing with this:
This is the same problem as observed in #2869; I think there's a problem with that test now. Maybe Amazon changed something? I'll open an issue. |
ac915b2
to
7b825d8
Compare
* brought provider scope to module level * Added env var to name kube job * Revert "brought provider scope to module level" This reverts commit 5dd0d24. * added is not * Revise variable description.
* brought provider scope to module level * Added env var to name kube job * Revert "brought provider scope to module level" This reverts commit 5dd0d24. * added is not * Revise variable description.
Added env var
TOIL_KUBERNETES_OWNER
to help identify different users kube jobs.