[PROC-252] add ContainerHostType field to all messages #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinconaway
reviewed
Apr 3, 2020
| @@ -93,6 +102,8 @@ message CollectorContainer { | |||
|
|
|||
| // Post-resolved fields | |||
| Host host = 8; | |||
|
|
|||
There was a problem hiding this comment.
Can we mark fields 6 & 7 as reserved if we aren't using them?
There was a problem hiding this comment.
I'm not sure whether they are used or not, grepping datadog-agent repo doesn't seem like it. I'll work on agent code first and come back to this clean up later.
There was a problem hiding this comment.
Fields 6 and 7 are still used by older agents and our tag handling code parses them so we'll have to keep them around for now unfortuantely.
shang-wang
changed the title
kevinconaway
reviewed
Apr 6, 2020
sunhay
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the only host related field for a container message is
HostName. The problem comes up when some types of containers are not running in host-based environment, for example fargate ECS and EKS.Currently we had to detect prefix in
HostNameto create special case for fargate containers in the backend host resolution. Having an additional field would provide backend more flexibility to generalize these cases.@DataDog/processes