add ContainerHostType on all message payloads to identify host type #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shang-wang
commented
Apr 5, 2020
Gopkg.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [[constraint]] | |||
| name = "github.com/DataDog/agent-payload" | |||
| version = "=4.29.0" | |||
| revision = "c192317fe7c4d65a0a0aafd768c134120637e512" | |||
There was a problem hiding this comment.
I will change this to version once the agent-payload PR is merge and versioned.
shang-wang
commented
Apr 6, 2020
Gopkg.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [[constraint]] | |||
| name = "github.com/DataDog/agent-payload" | |||
| version = "=4.29.0" | |||
| revision = "79d10f8bc542e3981ee156abe761e0d1398d5ae7" | |||
There was a problem hiding this comment.
I'll change this to version once the payload PR is merged and tagged.
shang-wang
changed the title
kevinconaway
approved these changes
Apr 8, 2020
|
@kevinconaway I asked and they don't need that, in those environments there's no resource that they are collecting. |
ahmed-mez
reviewed
Apr 8, 2020
| @@ -351,6 +357,17 @@ func NewSystemProbeConfig(loggerName config.LoggerName, yamlPath string) (*Agent | |||
| return cfg, nil | |||
| } | |||
|
|
|||
| // getContainerHostType uses the fargate library to detect container environment and returns the protobuf version of it | |||
| func getContainerHostType() model.ContainerHostType { | |||
| switch fargate.GetOrchestrator() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to use additional flag to indicate the host type for container collection. This will help the backend pipeline to resolve host in different situations, especially when containers are running in "hostless" environment like fargate in ECS and EKS.
DataDog/agent-payload#49
Motivation
@DataDog/processes
Additional Notes
Anything else we should know when reviewing?