Limit the versions of the agent that can be installed on Centos < 7 #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alopezz
force-pushed
the
alopez/deprecate-centos-6
branch
2 times, most recently
from
722508c
to
12e5b21
Compare
alopezz
force-pushed
the
alopez/deprecate-centos-6
branch
2 times, most recently
from
e110a52
to
f1c1a24
Compare
alopezz
force-pushed
the
alopez/deprecate-centos-6
branch
from
f1c1a24
to
1f13ef4
Compare
bkabrda
reviewed
Mar 8, 2024
tasks/os-check.yml
Outdated
| when: ansible_facts.os_family == "RedHat" | ||
| block: | ||
| - name: Get RHEL major version equivalent | ||
| command: "rpm -E %{rhel}" # noqa: command-instead-of-module |
There was a problem hiding this comment.
Hmm, this is interesting, I never thought about doing this. Have you tested on e.g. Scientific Linux 6? I feel like there might be rhel-6 based distros where this macro wouldn't expand, but I'm not sure.
There was a problem hiding this comment.
I did a quick test on a Scientific Linux 6 box and it did expand as expected (to 6). Would you say it's safer to use something else (or at least to have some sort of fallback)?
spencergilbert
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach taken here was: