Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI, local dev dockerfile setup, implement Centos 6 deprecation #913

Merged
merged 10 commits into from
Apr 11, 2024

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Mar 27, 2024

What does this PR do?

Motivation

BARX-282

Additional Notes

  • I tested the "erroring out on invalid pinned version" manually because I don't feel too confident on implementing those tests myself at this point.
  • I'd have rather split this in several PR's into several since it's tackling a few concerns at the same time, but I had no choice if I wanted to test things locally and the CI green.
  • Tests seem to work fine on Apple silicon (M1s, etc.), though they're expected to run more slowly due to the extra emulation layer.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

It failed in different ways; this mostly bumps the Ruby version and
changes the keyserver URL.
@alopezz alopezz requested review from a team as code owners March 27, 2024 14:51
Pythyu
Pythyu previously approved these changes Mar 27, 2024
Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need to wait that the docker kitchen tests still works before merge

Copy link

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion, thanks!

README.md Outdated Show resolved Hide resolved
@alopezz alopezz force-pushed the alopez/update-docker-test-env branch 6 times, most recently from 8dc678e to 102c4f8 Compare April 10, 2024 10:20
@alopezz alopezz force-pushed the alopez/update-docker-test-env branch from 102c4f8 to 724940a Compare April 10, 2024 10:50
@alopezz alopezz changed the title Fix docker_test_env Dockerfile to get it to build Fix failing CI, local dev dockerfile setup Apr 10, 2024
@alopezz alopezz changed the title Fix failing CI, local dev dockerfile setup Fix failing CI, local dev dockerfile setup, implement Centos 6 deprecation Apr 10, 2024
@alopezz alopezz force-pushed the alopez/update-docker-test-env branch from 3ea035a to 7d2bf61 Compare April 10, 2024 14:20
@alopezz alopezz requested a review from Pythyu April 11, 2024 06:48
@alopezz alopezz dismissed Pythyu’s stale review April 11, 2024 07:33

Significant changes since this review

Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my single comment LGTM 🚀

recipes/_install-linux.rb Show resolved Hide resolved
@alopezz alopezz merged commit 5948fbe into main Apr 11, 2024
13 checks passed
@alopezz alopezz deleted the alopez/update-docker-test-env branch April 11, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants