Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove centos 6 kitchen tests #914

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Remove centos 6 kitchen tests #914

merged 2 commits into from
Apr 10, 2024

Conversation

Pythyu
Copy link
Contributor

@Pythyu Pythyu commented Apr 10, 2024

What does this PR do?

Remove centos 6 tests following centos 6 deprecation and fixing main. Will need to be re-introduced into centos 6 pinned version test later (prbly via #913)

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

@Pythyu Pythyu requested a review from a team as a code owner April 10, 2024 12:28
Copy link

@chouquette chouquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you create a card for the "Will need to be reintroduced later" part so we don't forgot?

@alopezz
Copy link
Contributor

alopezz commented Apr 10, 2024

FYI I'm working on this: #913.

I'm also surprised that removing centos-6 tests fixes the centos-7 tests (which I'm trying to fix on that PR).

@Pythyu
Copy link
Contributor Author

Pythyu commented Apr 10, 2024

Yea I saw @alopezz'PR that's why I expect him to re-introduce the test once fixed. Just to unlock main for now 👍

@Pythyu Pythyu merged commit 360839c into main Apr 10, 2024
13 checks passed
@Pythyu Pythyu deleted the pythyu/centos6_deprecation branch April 10, 2024 12:57
alopezz added a commit that referenced this pull request May 8, 2024
alopezz added a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants