Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] allow the sec profile manager to communicate to the ADM to stop persisting unused dumps #29426

Closed
wants to merge 1 commit into from

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44693241 --os-family=ubuntu

Note: This applies to commit 90a576b

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Regression Detector

Regression Detector Results

Run ID: 795945a9-ec69-4f02-b8b4-f20fe1af8b26 Metrics dashboard Target profiles

Baseline: 3ffe79c
Comparison: 90a576b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +0.41 [-0.42, +1.25] 1 Logs
basic_py_check % cpu utilization +0.16 [-2.77, +3.10] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.12 [-0.89, +0.65] 1 Logs
file_tree memory utilization -0.23 [-0.34, -0.13] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.28 [-0.34, -0.22] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.49 [-3.10, +2.12] 1 Logs
idle memory utilization -0.85 [-0.90, -0.81] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 7/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pkg/security/security_profile/dump/storage_manager.go Outdated Show resolved Hide resolved
@@ -33,6 +34,9 @@ type ActivityDumpStorage interface {
type ActivityDumpStorageManager struct {
statsdClient statsd.ClientInterface
storages map[config.StorageType]ActivityDumpStorage

ilpiLock sync.Mutex
ignoreLocalPersistImages map[string]struct{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about pre-filling this list at startup with already present profile ?

@paulcacheux paulcacheux force-pushed the paulcacheux/stop-persist branch from f4958a1 to 90a576b Compare September 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants