Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: Report origin of generated service name #31226

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

vitkyrka
Copy link
Contributor

@vitkyrka vitkyrka commented Nov 19, 2024

What does this PR do?

Report the origin of the generated service name. See
https://datadoghq.atlassian.net/wiki/spaces/UT/pages/4397760938/ for more information.

Motivation

https://datadoghq.atlassian.net/browse/USMON-1351

Describe how to test/QA your changes

Automated tests are included in the PR.

Possible Drawbacks / Trade-offs

Additional Notes

@vitkyrka vitkyrka added changelog/no-changelog team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Nov 19, 2024
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Nov 19, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 19, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50122299 --os-family=ubuntu

Note: This applies to commit 3eecdcf

Copy link

cit-pr-commenter bot commented Nov 19, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fdb35181-3929-4ac7-8b81-aa8fb5f8924b

Baseline: bd7c058
Comparison: 3eecdcf
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization -5.20 [-8.54, -1.87] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.58 [+0.84, +2.31] 1 Logs
quality_gate_logs % cpu utilization +1.39 [-1.55, +4.34] 1 Logs
quality_gate_idle_all_features memory utilization +1.17 [+1.05, +1.29] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.49 [-0.29, +1.27] 1 Logs
file_tree memory utilization +0.10 [-0.05, +0.24] 1 Logs
quality_gate_idle memory utilization +0.07 [+0.03, +0.11] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.70, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.59, +0.68] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.89, +0.86] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.75, +0.69] 1 Logs
otel_to_otel_logs ingress throughput -0.13 [-0.83, +0.58] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.49 [-0.95, -0.03] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.02 [-1.08, -0.96] 1 Logs
basic_py_check % cpu utilization -2.33 [-6.16, +1.50] 1 Logs
pycheck_lots_of_tags % cpu utilization -5.20 [-8.54, -1.87] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 8/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Report the source of the generated service name.
@vitkyrka vitkyrka force-pushed the vincent.whitchurch/discovery-name-origin branch from 45e4af3 to f9f80f2 Compare November 26, 2024 15:30
@vitkyrka vitkyrka marked this pull request as ready for review November 27, 2024 09:05
@vitkyrka vitkyrka requested a review from a team as a code owner November 27, 2024 09:05
 Conflicts:
	pkg/collector/corechecks/servicediscovery/impl_linux_test.go
	pkg/collector/corechecks/servicediscovery/model/model.go
	pkg/collector/corechecks/servicediscovery/module/impl_linux.go
@vitkyrka
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 15:21:15 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.


2024-11-28 15:21:34 UTCMergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

Please wait for the conflicting merge request(s) to merge. After they have merged, resolve any conflicts and add this merge request to the queue again.

 Conflicts:
	pkg/collector/corechecks/servicediscovery/usm/python.go
 Conflicts:
	pkg/collector/corechecks/servicediscovery/impl_linux_test.go
	pkg/collector/corechecks/servicediscovery/module/impl_linux.go
@guyarb
Copy link
Contributor

guyarb commented Nov 28, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 19:50:14 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit cdc6007 into main Nov 28, 2024
293 checks passed
@dd-mergequeue dd-mergequeue bot deleted the vincent.whitchurch/discovery-name-origin branch November 28, 2024 20:09
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants