usm: go-tls: Add periodic process check

[vitkyrka]

What does this PR do?

Add a periodic check for new process to go-tls similar to the one used by istio and nodejs. This is to have a safety net to ensure that we don't missing hooking a program even if we happen to miss exec events in some case.

Motivation

https://datadoghq.atlassian.net/browse/USMON-694

Describe how to test/QA your changes

Manually tested by disabling the handleProcessExec and handleProcessExit callbacks in process_monitor.go (to ensure that no events are received) and checking that Go processes are still attached and detached (after the expected delay) using the debug level system-probe logs.

Possible Drawbacks / Trade-offs

Additional Notes

No significant increase seen in CPU load in load test. The new sync func takes about 4ms of CPU time per minute.

Load test results against 7.60-rc6

Profile from load test focusing on the sync function

Profile from staging cluster focusing on the sync function

[guyarb]

Did you run it through the load test and, dogfooding?

I'd like to ensure we're not introducing any performance regression

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 50060586 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50060586 --os-family=ubuntu

Note: This applies to commit d19135f

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0fdcde66-3053-4017-ab69-46d1c851991a

Baseline: c5298c3
Comparison: d19135f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	basic_py_check	% cpu utilization	+4.86	[+0.89, +8.83]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+1.08	[+0.39, +1.76]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.87	[+0.13, +1.61]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.76	[+0.62, +0.89]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.63	[+0.50, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.83, +0.86]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.10, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.70, +0.70]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.64, +0.63]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.04	[-0.51, +0.43]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.06	[-0.83, +0.71]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.08	[-0.85, +0.69]	1	Logs
➖	quality_gate_idle	memory utilization	-0.37	[-0.44, -0.29]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.80	[-0.86, -0.74]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-2.24	[-5.73, +1.25]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[vitkyrka]

Did you run it through the load test and, dogfooding?

I'd like to ensure we're not introducing any performance regression

I've add some info and links to the PR description.

[vitkyrka]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-11-28 15:00:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.