give pid files safe permissions. fixes #293.

DataDog · Dec 11, 2012 · 8cf9df5 · 8cf9df5
1 parent d245f44
commit 8cf9df5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/daemon.py b/daemon.py
@@ -96,7 +96,10 @@ def daemonize(self):
         atexit.register(self.delpid) # Make sure pid file is removed if we quit
         pid = str(os.getpid())
         try:
-            file(self.pidfile,'w+').write("%s\n" % pid)
+            fp = os.fdopen(os.open(self.pidfile, os.O_RDWR | os.O_CREAT | os.O_APPEND, 0644), 'w+')
+            fp.write("%s\n" % pid)
+            fp.close()
+            os.chmod(self.pidfile, 0644)
         except Exception, e:
             msg = "Unable to write pidfile: %s" % self.pidfile
             logger.exception(msg)