Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pid file 0644 instead of 0666 or 0777 #293

Closed
alq666 opened this issue Dec 11, 2012 · 4 comments
Closed

Make pid file 0644 instead of 0666 or 0777 #293

alq666 opened this issue Dec 11, 2012 · 4 comments
Assignees
@xcolour
Labels
request
Milestone
3.4.x

Comments

@alq666
Copy link
Member

alq666 commented Dec 11, 2012

Trips PCI scans.

  • /var/run/dd-agent/dogstatsd.pid
  • /var/run/dd-agent/dd-agent.pid
@alq666
Copy link
Member Author

alq666 commented Dec 11, 2012

The PidFile abstraction: it's an object where it should be a mere function. Or it should take care of writing itself instead of just encapsulating the name.

@ghost ghost assigned remh and xcolour Dec 11, 2012
@alq666 alq666 reopened this Dec 20, 2012
@alq666
Copy link
Member Author

alq666 commented Dec 20, 2012

  • /tmp/DogstatsdStatus.pickle
  • /tmp/CollectorStatus.pickle
  • /var/run/dd-agent/dogstatsd.pid
  • /var/run/dd-agent/dd-agent.pid

@alq666
Copy link
Member Author

alq666 commented Dec 20, 2012

os.umask is your friend.

xcolour pushed a commit that referenced this issue Dec 27, 2012
use umask to set all file permissions at once. fixes #293.
ab282e6
@clofresh
Copy link
Contributor

Fixed in 3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcolour xcolour

Labels
request
Projects
None yet
Milestone
3.4.x
Development

No branches or pull requests
4 participants
@clofresh @alq666 @xcolour @remh