Resolve connection issues on windows 2008 sp2 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great catch 👍 . Will psutil still work properly without these DLLs ? |
|
Yes, I tested on the machines I had at hand (win2008 R2 and win 2008 Sp2). |
remh
added a commit
that referenced
this pull request
Jul 22, 2014
Resolve connection issues on windows 2008 sp2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014
Psutil was bundling some system dlls with the agent. It wasn't a problem for most of the windows platform we were targetting because they had the same version but windows 2008 sp2 doesn't.