Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #4882

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[Test Package Versions Bump] Updating package versions #4882

merged 1 commit into from
Nov 24, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners November 16, 2023 17:24
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 16, 2023 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: ac6e6ee

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 217138 Passed, 613 Skipped, 23m 1.33s Wall Time

@andrewlock
Copy link
Member

andrewlock commented Nov 16, 2023 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4882) - mean (70ms)  : 60, 79
     .   : milestone, 70,
    master - mean (72ms)  : 61, 83
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (4882) - mean (990ms)  : 969, 1010
     .   : milestone, 990,
    master - mean (995ms)  : 973, 1018
     .   : milestone, 995,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4882) - mean (106ms)  : 102, 109
     .   : milestone, 106,
    master - mean (105ms)  : 102, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4882) - mean (684ms)  : 661, 707
     .   : milestone, 684,
    master - mean (683ms)  : 666, 701
     .   : milestone, 683,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4882) - mean (89ms)  : 86, 92
     .   : milestone, 89,
    master - mean (88ms)  : 84, 93
     .   : milestone, 88,

    section CallTarget+Inlining+NGEN
    This PR (4882) - mean (652ms)  : 624, 681
     .   : milestone, 652,
    master - mean (656ms)  : 631, 681
     .   : milestone, 656,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4882) - mean (188ms)  : 184, 191
     .   : milestone, 188,
    master - mean (188ms)  : 185, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4882) - mean (1,128ms)  : 1110, 1146
     .   : milestone, 1128,
    master - mean (1,132ms)  : 1108, 1156
     .   : milestone, 1132,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4882) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (272ms)  : 267, 277
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4882) - mean (1,092ms)  : 1059, 1125
     .   : milestone, 1092,
    master - mean (1,087ms)  : 1054, 1121
     .   : milestone, 1087,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4882) - mean (261ms)  : 256, 265
     .   : milestone, 261,
    master - mean (261ms)  : 258, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (4882) - mean (1,054ms)  : 1031, 1078
     .   : milestone, 1054,
    master - mean (1,056ms)  : 1037, 1076
     .   : milestone, 1056,
Loading

@andrewlock
Copy link
Member

andrewlock commented Nov 17, 2023 •
edited
Loading

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4882) (10.926M)   : 0, 10925957
    master (10.972M)   : 0, 10972349
    benchmarks/2.9.0 (11.683M)   : 0, 11682730

    section Automatic
    This PR (4882) (7.702M)   : 0, 7701802
    master (7.507M)   : 0, 7507492
    benchmarks/2.9.0 (8.466M)   : 0, 8466123

    section Trace stats
    This PR (4882) (8.017M)   : 0, 8017422
    master (7.705M)   : 0, 7704547

    section Manual
    This PR (4882) (9.438M)   : 0, 9438485
    master (9.415M)   : 0, 9414855

    section Manual + Automatic
    This PR (4882) (7.040M)   : 0, 7040180
    master (7.083M)   : 0, 7083074

    section Version Conflict
    This PR (4882) (6.341M)   : 0, 6340536
    master (6.305M)   : 0, 6305030
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4882) (9.486M)   : 0, 9485512
    master (9.433M)   : 0, 9433276
    benchmarks/2.9.0 (9.501M)   : 0, 9501348

    section Automatic
    This PR (4882) (6.604M)   : 0, 6603797
    master (6.675M)   : 0, 6675058

    section Trace stats
    This PR (4882) (6.774M)   : 0, 6774131
    master (6.651M)   : 0, 6650587

    section Manual
    This PR (4882) (8.330M)   : 0, 8330416
    master (8.284M)   : 0, 8284190

    section Manual + Automatic
    This PR (4882) (6.220M)   : 0, 6220056
    master (6.291M)   : 0, 6290644

    section Version Conflict
    This PR (4882) (5.574M)   : 0, 5574457
    master (5.668M)   : 0, 5668375
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4882) (10.321M)   : 0, 10320807
    benchmarks/2.9.0 (10.646M)   : 0, 10646425

    section Automatic
    This PR (4882) (7.129M)   : 0, 7129363
    benchmarks/2.9.0 (7.738M)   : 0, 7737732

    section Trace stats
    This PR (4882) (7.609M)   : 0, 7608545

    section Manual
    This PR (4882) (8.862M)   : 0, 8861952

    section Manual + Automatic
    This PR (4882) (6.986M)   : 0, 6986460

    section Version Conflict
    This PR (4882) (6.461M)   : 0, 6460926
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.345M)   : 0, 7344736
    benchmarks/2.9.0 (7.766M)   : 0, 7765742

    section No attack
    master (1.997M)   : 0, 1997497
    benchmarks/2.9.0 (3.225M)   : 0, 3225290

    section Attack
    master (1.553M)   : 0, 1552563
    benchmarks/2.9.0 (2.447M)   : 0, 2447478

    section Blocking
    master (3.301M)   : 0, 3300809

    section IAST default
    master (6.465M)   : 0, 6464879

    section IAST full
    master (5.858M)   : 0, 5857939

    section Base vuln
    master (0.943M)   : 0, 942569

    section IAST vuln
    master (0.873M)   : 0, 873217
Loading

@andrewlock
Copy link
Member

andrewlock commented Nov 17, 2023 •
edited
Loading

Benchmarks Report 🐌

Benchmarks for #4882 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.495
  • 3 benchmarks are slower, with geometric mean 1.168
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.82μs 48.7ns 308ns 0.0213 0.00851 0 7.48 KB
master StartStopWithChild netcoreapp3.1 11.1μs 60.6ns 343ns 0.0276 0.00689 0 7.57 KB
master StartStopWithChild net472 17.3μs 45.7ns 177ns 1.35 0.355 0.121 7.96 KB
#4882 StartStopWithChild net6.0 8.81μs 49.6ns 325ns 0.0215 0.00858 0 7.48 KB
#4882 StartStopWithChild netcoreapp3.1 10.8μs 61.6ns 426ns 0.0301 0.0151 0.00502 7.58 KB
#4882 StartStopWithChild net472 17.1μs 30.4ns 114ns 1.32 0.329 0.11 7.95 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 451μs 103ns 386ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 310ns 1.07μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 782μs 288ns 1.04μs 0.388 0 0 3.3 KB
#4882 WriteAndFlushEnrichedTraces net6.0 481μs 203ns 758ns 0 0 0 2.7 KB
#4882 WriteAndFlushEnrichedTraces netcoreapp3.1 619μs 282ns 1.06μs 0 0 0 2.7 KB
#4882 WriteAndFlushEnrichedTraces net472 777μs 245ns 948ns 0.386 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4882

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.267 180.58 228.75

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 43.9μs 124ns 479ns 0.0216 0 0 1.77 KB
master AllCycleSimpleBody netcoreapp3.1 47.4μs 119ns 461ns 0.0236 0 0 1.74 KB
master AllCycleSimpleBody net472 49.1μs 75.9ns 294ns 0.272 0 0 1.81 KB
master AllCycleMoreComplexBody net6.0 214μs 111ns 415ns 0.106 0 0 9.25 KB
master AllCycleMoreComplexBody netcoreapp3.1 224μs 365ns 1.41μs 0.112 0 0 9.14 KB
master AllCycleMoreComplexBody net472 237μs 69.3ns 259ns 1.42 0 0 9.32 KB
master ObjectExtractorSimpleBody net6.0 130ns 0.0353ns 0.127ns 0.00394 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 181ns 0.0881ns 0.341ns 0.00372 0 0 272 B
master ObjectExtractorSimpleBody net472 151ns 0.222ns 0.861ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.84μs 1.38ns 5.15ns 0.0527 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.79μs 1.4ns 5.06ns 0.0509 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.5μs 1.64ns 6.12ns 0.603 0.00524 0 3.8 KB
#4882 AllCycleSimpleBody net6.0 43.9μs 22.6ns 87.4ns 0.0219 0 0 1.77 KB
#4882 AllCycleSimpleBody netcoreapp3.1 46.6μs 118ns 457ns 0.0232 0 0 1.74 KB
#4882 AllCycleSimpleBody net472 49.9μs 58.7ns 227ns 0.274 0 0 1.81 KB
#4882 AllCycleMoreComplexBody net6.0 213μs 185ns 1.17μs 0.106 0 0 9.25 KB
#4882 AllCycleMoreComplexBody netcoreapp3.1 223μs 219ns 849ns 0.112 0 0 9.14 KB
#4882 AllCycleMoreComplexBody net472 237μs 115ns 429ns 1.41 0 0 9.32 KB
#4882 ObjectExtractorSimpleBody net6.0 131ns 0.055ns 0.206ns 0.00391 0 0 280 B
#4882 ObjectExtractorSimpleBody netcoreapp3.1 229ns 0.104ns 0.404ns 0.00379 0 0 272 B
#4882 ObjectExtractorSimpleBody net472 152ns 0.0816ns 0.316ns 0.0446 0 0 281 B
#4882 ObjectExtractorMoreComplexBody net6.0 2.95μs 1.24ns 4.8ns 0.0526 0 0 3.78 KB
#4882 ObjectExtractorMoreComplexBody netcoreapp3.1 3.57μs 0.68ns 2.54ns 0.05 0 0 3.69 KB
#4882 ObjectExtractorMoreComplexBody net472 3.52μs 2.66ns 10.3ns 0.602 0.00528 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 51μs 185ns 691ns 0.223 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 67μs 318ns 1.27μs 0.201 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) net472 97μs 91.1ns 329ns 2.52 0.095 0 16.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 118μs 508ns 2.54μs 0.286 0 0 22.41 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 135μs 645ns 2.5μs 0.265 0 0 22.36 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 166μs 63.5ns 237ns 3.55 0.165 0 22.7 KB
master RunWaf(args=NestedMap (100)) net6.0 99.6μs 262ns 980ns 0.445 0 0 32.76 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 135μs 560ns 2.17μs 0.442 0 0 33.33 KB
master RunWaf(args=NestedMap (100)) net472 183μs 74.5ns 279ns 5.3 0.365 0 33.67 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 165μs 106ns 369ns 0.524 0 0 39.1 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 211μs 1.09μs 5.56μs 0.52 0 0 39.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 266μs 1.25μs 4.85μs 6.37 0.52 0 40.23 KB
master RunWaf(args=NestedMap (20)) net6.0 94μs 17.6ns 66ns 0.461 0 0 32.18 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 131μs 750ns 5.46μs 0.41 0 0 32.3 KB
master RunWaf(args=NestedMap (20)) net472 189μs 871ns 3.48μs 5.19 0.364 0 32.63 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 168μs 67.4ns 234ns 0.512 0 0 38.53 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 210μs 813ns 3.04μs 0.517 0 0 38.6 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 263μs 1.24μs 4.8μs 6.2 0.517 0 39.2 KB
#4882 RunWaf(args=NestedMap (10)) net6.0 48.7μs 19.3ns 72.4ns 0.22 0 0 16.06 KB
#4882 RunWaf(args=NestedMap (10)) netcoreapp3.1 67.1μs 376ns 2.61μs 0.204 0 0 16.06 KB
#4882 RunWaf(args=NestedMap (10)) net472 96μs 510ns 2.65μs 2.56 0.093 0 16.14 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 123μs 497ns 1.72μs 0.302 0 0 22.41 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 137μs 670ns 2.92μs 0.268 0 0 22.36 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [22]) net472 167μs 88.6ns 319ns 3.57 0.166 0 22.7 KB
#4882 RunWaf(args=NestedMap (100)) net6.0 96.2μs 546ns 4.01μs 0.451 0 0 32.76 KB
#4882 RunWaf(args=NestedMap (100)) netcoreapp3.1 125μs 205ns 709ns 0.458 0 0 33.33 KB
#4882 RunWaf(args=NestedMap (100)) net472 184μs 812ns 3.15μs 5.28 0.364 0 33.67 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 165μs 492ns 1.77μs 0.524 0 0 39.1 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 204μs 561ns 2.17μs 0.523 0 0 39.63 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [23]) net472 268μs 98.7ns 342ns 6.33 0.517 0 40.23 KB
#4882 RunWaf(args=NestedMap (20)) net6.0 99.4μs 52.7ns 197ns 0.43 0 0 32.18 KB
#4882 RunWaf(args=NestedMap (20)) netcoreapp3.1 132μs 334ns 1.25μs 0.402 0 0 32.3 KB
#4882 RunWaf(args=NestedMap (20)) net472 187μs 831ns 3.22μs 5.11 0.365 0 32.63 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 177μs 924ns 4.43μs 0.495 0 0 38.53 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 200μs 888ns 3.44μs 0.496 0 0 38.6 KB
#4882 RunWafWithAttack(args=Neste(...)tack) [22]) net472 262μs 395ns 1.53μs 6.17 0.394 0 39.2 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 102ns 382ns 0.171 0 0 18.24 KB
master SendRequest netcoreapp3.1 193μs 326ns 1.26μs 0.193 0 0 20.4 KB
master SendRequest net472 0.000229ns 0.000146ns 0.000547ns 0 0 0 0 b
#4882 SendRequest net6.0 171μs 170ns 657ns 0.171 0 0 18.24 KB
#4882 SendRequest netcoreapp3.1 192μs 238ns 922ns 0.192 0 0 20.4 KB
#4882 SendRequest net472 4.5E‑05ns 4.3E‑05ns 0.000166ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 558μs 327ns 1.27μs 0.543 0 0 41.88 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 1.26μs 4.88μs 0.326 0 0 41.79 KB
master WriteAndFlushEnrichedTraces net472 848μs 3.6μs 13.9μs 8.13 2.57 0.428 53.23 KB
#4882 WriteAndFlushEnrichedTraces net6.0 554μs 322ns 1.21μs 0.532 0 0 41.87 KB
#4882 WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 1.64μs 6.34μs 0.321 0 0 41.77 KB
#4882 WriteAndFlushEnrichedTraces net472 837μs 2.99μs 11.6μs 8.33 2.5 0.417 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.04μs 0.621ns 2.32ns 0.0108 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.51μs 1.93ns 7.21ns 0.0105 0 0 768 B
master ExecuteNonQuery net472 1.74μs 1.01ns 3.48ns 0.115 0.000867 0 730 B
#4882 ExecuteNonQuery net6.0 1.1μs 0.501ns 1.87ns 0.0104 0 0 768 B
#4882 ExecuteNonQuery netcoreapp3.1 1.53μs 1.2ns 4.64ns 0.00999 0 0 768 B
#4882 ExecuteNonQuery net472 1.65μs 1.23ns 4.45ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4882

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.120 1,165.66 1,305.24

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 1.02ns 3.97ns 0.0132 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.5μs 1.07ns 4.01ns 0.0128 0 0 936 B
master CallElasticsearch net472 2.51μs 0.633ns 2.45ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.33μs 0.539ns 2.02ns 0.0126 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 1.07ns 4.01ns 0.0134 0 0 984 B
master CallElasticsearchAsync net472 2.67μs 0.937ns 3.63ns 0.16 0 0 1.01 KB
#4882 CallElasticsearch net6.0 1.3μs 0.809ns 3.03ns 0.0131 0 0 936 B
#4882 CallElasticsearch netcoreapp3.1 1.5μs 1.5ns 5.6ns 0.0128 0 0 936 B
#4882 CallElasticsearch net472 2.49μs 0.439ns 1.58ns 0.151 0 0 955 B
#4882 CallElasticsearchAsync net6.0 1.22μs 0.63ns 2.44ns 0.0123 0 0 912 B
#4882 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.86ns 3.22ns 0.0132 0 0 984 B
#4882 CallElasticsearchAsync net472 2.64μs 0.708ns 2.74ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.42μs 0.658ns 2.46ns 0.0127 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.64μs 1.49ns 5.78ns 0.0122 0 0 912 B
master ExecuteAsync net472 1.86μs 0.47ns 1.76ns 0.139 0.000926 0 875 B
#4882 ExecuteAsync net6.0 1.32μs 1.02ns 3.83ns 0.0128 0 0 912 B
#4882 ExecuteAsync netcoreapp3.1 1.6μs 1.02ns 3.69ns 0.012 0 0 912 B
#4882 ExecuteAsync net472 1.79μs 0.715ns 2.77ns 0.138 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.07μs 1.03ns 3.84ns 0.0285 0 0 2.1 KB
master SendAsync netcoreapp3.1 4.9μs 2.11ns 8.18ns 0.0348 0 0 2.63 KB
master SendAsync net472 7.72μs 1.87ns 7.25ns 0.522 0 0 3.31 KB
#4882 SendAsync net6.0 4.04μs 1.1ns 4.28ns 0.0283 0 0 2.1 KB
#4882 SendAsync netcoreapp3.1 4.85μs 3.23ns 11.6ns 0.0362 0 0 2.63 KB
#4882 SendAsync net472 7.76μs 3.59ns 13.9ns 0.523 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #4882

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net6.0 1.495 98,100.00 65,600.00

More allocations ⚠️ in #4882

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net472 58.52 KB 59.7 KB 1.18 KB 2.01%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 59μs 755ns 7.51μs 0 0 0 43.44 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 59.8μs 767ns 7.48μs 0 0 0 42.64 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 38.2μs 123ns 459ns 0 0 0 58.52 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 92.5μs 1.72μs 15.9μs 0 0 0 43.29 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 96.5μs 2.52μs 24.7μs 0 0 0 42.64 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 62μs 140ns 484ns 0 0 0 57.34 KB
#4882 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 58.8μs 781ns 7.77μs 0 0 0 43.44 KB
#4882 StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 52.7μs 245ns 883ns 0 0 0 42.64 KB
#4882 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 37.9μs 63.2ns 219ns 0 0 0 59.7 KB
#4882 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 65.5μs 318ns 1.23μs 0 0 0 43.29 KB
#4882 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 103μs 3.01μs 30.1μs 0 0 0 42.64 KB
#4882 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 61.8μs 244ns 945ns 0 0 0 57.34 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.59μs 0.859ns 3.22ns 0.0215 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 2.16μs 0.934ns 3.5ns 0.0208 0 0 1.57 KB
master EnrichedLog net472 2.56μs 2.92ns 10.9ns 0.237 0 0 1.5 KB
#4882 EnrichedLog net6.0 1.56μs 0.859ns 3.21ns 0.022 0 0 1.57 KB
#4882 EnrichedLog netcoreapp3.1 2.22μs 1.17ns 4.39ns 0.0212 0 0 1.57 KB
#4882 EnrichedLog net472 2.67μs 3.99ns 15.5ns 0.237 0 0 1.5 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 257ns 994ns 0.0561 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 117μs 200ns 776ns 0 0 0 4.21 KB
master EnrichedLog net472 148μs 146ns 566ns 0.664 0.221 0 4.39 KB
#4882 EnrichedLog net6.0 112μs 88.2ns 330ns 0.0557 0 0 4.21 KB
#4882 EnrichedLog netcoreapp3.1 117μs 206ns 796ns 0.0586 0 0 4.21 KB
#4882 EnrichedLog net472 146μs 98.7ns 382ns 0.659 0.22 0 4.39 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 1.04ns 3.88ns 0.0295 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 4.25μs 1.97ns 7.63ns 0.0298 0 0 2.13 KB
master EnrichedLog net472 4.78μs 4.17ns 15.6ns 0.309 0 0 1.95 KB
#4882 EnrichedLog net6.0 2.94μs 2.2ns 8.54ns 0.0293 0 0 2.13 KB
#4882 EnrichedLog netcoreapp3.1 4.3μs 1.98ns 7.41ns 0.028 0 0 2.13 KB
#4882 EnrichedLog net472 4.86μs 5.13ns 19.9ns 0.308 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 0.589ns 2.2ns 0.0153 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.72μs 0.737ns 2.85ns 0.0146 0 0 1.1 KB
master SendReceive net472 2.15μs 1.64ns 6.35ns 0.177 0 0 1.12 KB
#4882 SendReceive net6.0 1.42μs 1.38ns 5.33ns 0.0156 0 0 1.1 KB
#4882 SendReceive netcoreapp3.1 1.8μs 0.526ns 1.97ns 0.0144 0 0 1.1 KB
#4882 SendReceive net472 2.24μs 3.05ns 11.8ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 0.583ns 2.1ns 0.0211 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.92μs 1.94ns 7.5ns 0.0215 0 0 1.58 KB
master EnrichedLog net472 4.3μs 1.1ns 4.1ns 0.312 0 0 1.97 KB
#4882 EnrichedLog net6.0 2.78μs 0.83ns 3.22ns 0.022 0 0 1.53 KB
#4882 EnrichedLog netcoreapp3.1 3.93μs 1.17ns 4.38ns 0.0215 0 0 1.58 KB
#4882 EnrichedLog net472 4.32μs 1.29ns 4.99ns 0.312 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4882

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.124 647.14 727.13

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 517ns 0.143ns 0.553ns 0.00754 0 0 536 B
master StartFinishSpan netcoreapp3.1 647ns 0.254ns 0.917ns 0.00741 0 0 536 B
master StartFinishSpan net472 779ns 0.451ns 1.75ns 0.0854 0 0 538 B
master StartFinishScope net6.0 591ns 0.171ns 0.641ns 0.00916 0 0 656 B
master StartFinishScope netcoreapp3.1 897ns 1.36ns 4.91ns 0.00909 0 0 656 B
master StartFinishScope net472 1μs 0.391ns 1.46ns 0.0981 0 0 618 B
#4882 StartFinishSpan net6.0 503ns 0.171ns 0.661ns 0.00745 0 0 536 B
#4882 StartFinishSpan netcoreapp3.1 727ns 0.192ns 0.743ns 0.00722 0 0 536 B
#4882 StartFinishSpan net472 760ns 0.118ns 0.441ns 0.0854 0 0 538 B
#4882 StartFinishScope net6.0 627ns 0.266ns 1.03ns 0.00914 0 0 656 B
#4882 StartFinishScope netcoreapp3.1 944ns 0.276ns 1.03ns 0.00897 0 0 656 B
#4882 StartFinishScope net472 983ns 0.325ns 1.26ns 0.098 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 713ns 0.483ns 1.87ns 0.00896 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 961ns 0.408ns 1.53ns 0.00893 0 0 656 B
master RunOnMethodBegin net472 1.2μs 0.446ns 1.67ns 0.0982 0 0 618 B
#4882 RunOnMethodBegin net6.0 680ns 0.15ns 0.541ns 0.0091 0 0 656 B
#4882 RunOnMethodBegin netcoreapp3.1 1.04μs 0.487ns 1.88ns 0.0088 0 0 656 B
#4882 RunOnMethodBegin net472 1.17μs 0.589ns 2.28ns 0.0981 0 0 618 B

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch 4 times, most recently from 70b8012 to f706c80 Compare November 21, 2023 16:38
@andrewlock andrewlock requested a review from a team November 22, 2023 14:04
@github-actions GitHub Actions
Copy link
Contributor Author

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

4 occurrences of :

-    Resource: POST localhost:00000/?/MyAsyncSQSQueue,
+    Resource: POST localhost:00000/,

64 occurrences of :

-      http.url: http://localhost:00000/000000000000/MyAsyncSQSQueue,
+      http.url: http://localhost:00000/,

4 occurrences of :

-    Resource: POST localhost:00000/?/MyAsyncSQSQueue2,
+    Resource: POST localhost:00000/,

48 occurrences of :

-      http.url: http://localhost:00000/000000000000/MyAsyncSQSQueue2,
+      http.url: http://localhost:00000/,

2 occurrences of :

-    Resource: POST localhost:00000/?/MySyncSQSQueue,
+    Resource: POST localhost:00000/,

32 occurrences of :

-      http.url: http://localhost:00000/000000000000/MySyncSQSQueue,
+      http.url: http://localhost:00000/,

2 occurrences of :

-    Resource: POST localhost:00000/?/MySyncSQSQueue2,
+    Resource: POST localhost:00000/,

24 occurrences of :

-      http.url: http://localhost:00000/000000000000/MySyncSQSQueue2,
+      http.url: http://localhost:00000/,

@andrewlock andrewlock mentioned this pull request Nov 22, 2023
Merged
@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 6a0d261 to ac6e6ee Compare November 23, 2023 16:48
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 23, 2023 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: ac6e6ee

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 303008 Passed, 939 Skipped, 36m 12.77s Wall Time

andrewlock
andrewlock approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock andrewlock merged commit eda4fe2 into master Nov 24, 2023
45 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch November 24, 2023 15:31
@github-actions github-actions bot added this to the vNext milestone Nov 24, 2023
@andrewlock andrewlock added area:test-apps apps used to test integrations area:dependabot dependabot updates labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations
Projects
None yet
Milestone
2.43.0
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock