Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory dumps on artifact tests #4906

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Fix memory dumps on artifact tests #4906

merged 10 commits into from
Dec 1, 2023

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Uploading the memory dumps in artifact tests is broken for a variety of reasons.

Reason for change

Those poor little dumps feel lonely on their CI agent.

Test coverage

Making Samples.Console freeze on purpose to test.

@kevingosse kevingosse requested review from a team as code owners November 21, 2023 17:42
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 21, 2023 •
edited
Loading

Datadog Report

Branch report: kevin/artifacts_dumps
Commit report: 81d707f

❌ dd-trace-dotnet: 5 Failed (0 Known Flaky), 0 New Flaky, 303054 Passed, 952 Skipped, 45m 16.01s Wall Time

❌ Failed Tests (5)

  • DetectRuntime - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - Details

    Expand for error 
     Timeout when waiting for the target process to start

  • DetectRuntime - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - Details

    Expand for error 
     Timeout when waiting for the target process to start

  • DetectRuntime - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - Details

    Expand for error 
     Timeout when waiting for the target process to start

  • DetectRuntime - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - Details

    Expand for error 
     Timeout when waiting for the target process to start

  • DetectRuntime - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - Details

    Expand for error 
     Timeout when waiting for the target process to start

@andrewlock
Copy link
Member

andrewlock commented Nov 21, 2023 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4906) - mean (70ms)  : 63, 77
     .   : milestone, 70,
    master - mean (71ms)  : 60, 83
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4906) - mean (993ms)  : 967, 1019
     .   : milestone, 993,
    master - mean (998ms)  : 972, 1023
     .   : milestone, 998,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4906) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (107ms)  : 102, 112
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (4906) - mean (687ms)  : 661, 713
     .   : milestone, 687,
    master - mean (691ms)  : 668, 714
     .   : milestone, 691,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4906) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4906) - mean (661ms)  : 632, 689
     .   : milestone, 661,
    master - mean (660ms)  : 638, 682
     .   : milestone, 660,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4906) - mean (188ms)  : 187, 190
     .   : milestone, 188,
    master - mean (189ms)  : 186, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4906) - mean (1,131ms)  : 1106, 1156
     .   : milestone, 1131,
    master - mean (1,137ms)  : 1112, 1161
     .   : milestone, 1137,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4906) - mean (272ms)  : 268, 276
     .   : milestone, 272,
    master - mean (272ms)  : 269, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4906) - mean (1,094ms)  : 1072, 1115
     .   : milestone, 1094,
    master - mean (1,088ms)  : 1062, 1115
     .   : milestone, 1088,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4906) - mean (262ms)  : 259, 266
     .   : milestone, 262,
    master - mean (262ms)  : 259, 264
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4906) - mean (1,058ms)  : 1038, 1078
     .   : milestone, 1058,
    master - mean (1,062ms)  : 1033, 1091
     .   : milestone, 1062,
Loading

@andrewlock
Copy link
Member

andrewlock commented Nov 22, 2023 •
edited
Loading

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4906) (10.841M)   : 0, 10840505
    master (11.333M)   : 0, 11332518
    benchmarks/2.9.0 (11.258M)   : 0, 11257868

    section Automatic
    This PR (4906) (7.570M)   : 0, 7569581
    master (7.657M)   : 0, 7657438
    benchmarks/2.9.0 (8.046M)   : 0, 8046105

    section Trace stats
    This PR (4906) (7.824M)   : 0, 7823717
    master (8.054M)   : 0, 8053668

    section Manual
    This PR (4906) (9.453M)   : crit ,0, 9453309
    master (10.004M)   : 0, 10003794

    section Manual + Automatic
    This PR (4906) (7.172M)   : 0, 7171782
    master (7.437M)   : 0, 7436536

    section Version Conflict
    This PR (4906) (6.450M)   : 0, 6450219
    master (6.771M)   : 0, 6770626
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4906) (9.583M)   : 0, 9582534
    master (9.642M)   : 0, 9641863
    benchmarks/2.9.0 (9.571M)   : 0, 9571091

    section Automatic
    This PR (4906) (6.487M)   : 0, 6487487
    master (6.503M)   : 0, 6503245

    section Trace stats
    This PR (4906) (6.876M)   : 0, 6875876
    master (6.987M)   : 0, 6987377

    section Manual
    This PR (4906) (8.381M)   : 0, 8381377
    master (8.537M)   : 0, 8536637

    section Manual + Automatic
    This PR (4906) (6.133M)   : 0, 6132922
    master (6.089M)   : 0, 6089321

    section Version Conflict
    This PR (4906) (5.716M)   : 0, 5716220
    master (5.724M)   : 0, 5723643
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4906) (10.865M)   : 0, 10864958
    master (10.254M)   : 0, 10253707
    benchmarks/2.9.0 (8.981M)   : 0, 8981100

    section Automatic
    This PR (4906) (7.700M)   : 0, 7699952
    master (6.421M)   : 0, 6420836
    benchmarks/2.9.0 (6.621M)   : 0, 6621015

    section Trace stats
    This PR (4906) (8.162M)   : 0, 8161847
    master (6.589M)   : 0, 6589319

    section Manual
    This PR (4906) (9.568M)   : 0, 9567910
    master (7.901M)   : 0, 7900787

    section Manual + Automatic
    This PR (4906) (7.516M)   : 0, 7515891
    master (6.157M)   : 0, 6157174

    section Version Conflict
    This PR (4906) (6.697M)   : 0, 6696576
    master (5.598M)   : 0, 5598196
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.353M)   : 0, 7352773
    benchmarks/2.9.0 (7.805M)   : 0, 7805126

    section No attack
    master (1.971M)   : 0, 1971063
    benchmarks/2.9.0 (3.177M)   : 0, 3177224

    section Attack
    master (1.553M)   : 0, 1553355
    benchmarks/2.9.0 (2.505M)   : 0, 2504790

    section Blocking
    master (3.237M)   : 0, 3236693

    section IAST default
    master (6.655M)   : 0, 6654796

    section IAST full
    master (5.949M)   : 0, 5949094

    section Base vuln
    master (0.974M)   : 0, 974472

    section IAST vuln
    master (0.921M)   : 0, 920725
Loading

andrewlock
andrewlock approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works

tracer/test/Datadog.Trace.TestHelpers/CustomTestFramework.cs Outdated Show resolved Hide resolved
tracer/test/test-applications/integrations/Samples.Console/Program.cs Outdated
Comment on lines 13 to 14
Thread.Sleep(Timeout.Infinite); // Look Ma I'm frozen!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove this afterwards 😅

Suggested change
Thread.Sleep(Timeout.Infinite); // Look Ma I'm frozen!

@andrewlock
Copy link
Member

FYI, saw this error in the artifact logs (Windows)

##[error]Path does not exist: D:\a\1\s\tracer\build_data

So you should probably update the Nuke task to ensure this directory is created before running the artifact tests, otherwise you'll get "partial failures" on successful runs

@andrewlock
Copy link
Member

andrewlock commented Nov 27, 2023 •
edited
Loading

Benchmarks Report 🐌

Benchmarks for #4906 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.236
  • 1 benchmarks are slower, with geometric mean 1.115
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.87μs 49.2ns 311ns 0.019 0.00951 0 7.48 KB
master StartStopWithChild netcoreapp3.1 11.2μs 62.4ns 419ns 0.0278 0.0111 0 7.57 KB
master StartStopWithChild net472 17.7μs 61.2ns 237ns 1.34 0.357 0.113 7.96 KB
#4906 StartStopWithChild net6.0 8.47μs 42.3ns 216ns 0.0225 0.00901 0 7.48 KB
#4906 StartStopWithChild netcoreapp3.1 10.7μs 60.1ns 389ns 0.0211 0.00526 0 7.58 KB
#4906 StartStopWithChild net472 17.1μs 43.5ns 168ns 1.35 0.365 0.113 7.94 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 454μs 154ns 577ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 1.85μs 7.15μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 776μs 343ns 1.24μs 0.386 0 0 3.3 KB
#4906 WriteAndFlushEnrichedTraces net6.0 472μs 205ns 792ns 0 0 0 2.7 KB
#4906 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 348ns 1.26μs 0 0 0 2.7 KB
#4906 WriteAndFlushEnrichedTraces net472 771μs 348ns 1.3μs 0.383 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4906

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 1.115 3,414.99 3,808.25

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 44.2μs 25.7ns 96.1ns 0.0223 0 0 1.77 KB
master AllCycleSimpleBody netcoreapp3.1 47.3μs 204ns 791ns 0.0235 0 0 1.74 KB
master AllCycleSimpleBody net472 49.4μs 22.6ns 87.5ns 0.273 0 0 1.81 KB
master AllCycleMoreComplexBody net6.0 213μs 198ns 767ns 0.106 0 0 9.25 KB
master AllCycleMoreComplexBody netcoreapp3.1 228μs 161ns 602ns 0.113 0 0 9.14 KB
master AllCycleMoreComplexBody net472 237μs 69.6ns 251ns 1.42 0 0 9.32 KB
master ObjectExtractorSimpleBody net6.0 129ns 0.0422ns 0.146ns 0.00396 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 188ns 0.201ns 1ns 0.00369 0 0 272 B
master ObjectExtractorSimpleBody net472 152ns 0.115ns 0.432ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.81μs 1.39ns 5.21ns 0.0537 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.66μs 1.54ns 5.96ns 0.0493 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.42μs 2.57ns 9.95ns 0.602 0.00513 0 3.8 KB
#4906 AllCycleSimpleBody net6.0 44.2μs 32.3ns 125ns 0.0219 0 0 1.77 KB
#4906 AllCycleSimpleBody netcoreapp3.1 46.7μs 40.9ns 159ns 0 0 0 1.74 KB
#4906 AllCycleSimpleBody net472 49.1μs 89ns 333ns 0.265 0 0 1.81 KB
#4906 AllCycleMoreComplexBody net6.0 215μs 337ns 1.26μs 0.106 0 0 9.25 KB
#4906 AllCycleMoreComplexBody netcoreapp3.1 224μs 196ns 732ns 0.112 0 0 9.14 KB
#4906 AllCycleMoreComplexBody net472 239μs 91.8ns 356ns 1.43 0 0 9.32 KB
#4906 ObjectExtractorSimpleBody net6.0 128ns 0.0414ns 0.155ns 0.00392 0 0 280 B
#4906 ObjectExtractorSimpleBody netcoreapp3.1 185ns 0.135ns 0.524ns 0.00372 0 0 272 B
#4906 ObjectExtractorSimpleBody net472 154ns 0.22ns 0.851ns 0.0446 0 0 281 B
#4906 ObjectExtractorMoreComplexBody net6.0 2.78μs 1.85ns 6.94ns 0.053 0 0 3.78 KB
#4906 ObjectExtractorMoreComplexBody netcoreapp3.1 3.61μs 2ns 7.74ns 0.0488 0 0 3.69 KB
#4906 ObjectExtractorMoreComplexBody net472 3.81μs 1.97ns 7.36ns 0.602 0.00571 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 54.3μs 20.6ns 77.1ns 0.22 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 68.1μs 355ns 1.85μs 0.2 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) net472 97.5μs 419ns 1.62μs 2.52 0.0935 0 16.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 114μs 36.9ns 138ns 0.302 0 0 22.41 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 139μs 614ns 3.79μs 0.27 0 0 22.36 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 172μs 96.4ns 361ns 3.58 0.166 0 22.7 KB
master RunWaf(args=NestedMap (100)) net6.0 93.1μs 25.4ns 98.4ns 0.425 0 0 32.76 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 125μs 372ns 1.34μs 0.457 0 0 33.33 KB
master RunWaf(args=NestedMap (100)) net472 184μs 128ns 497ns 5.29 0.365 0 33.67 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 165μs 83.6ns 324ns 0.497 0 0 39.1 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 210μs 82.8ns 299ns 0.526 0 0 39.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 261μs 128ns 480ns 6.39 0.522 0 40.23 KB
master RunWaf(args=NestedMap (20)) net6.0 97.1μs 158ns 610ns 0.455 0 0 32.18 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 135μs 209ns 810ns 0.4 0 0 32.3 KB
master RunWaf(args=NestedMap (20)) net472 188μs 202ns 784ns 5.19 0.37 0 32.63 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 165μs 674ns 2.61μs 0.488 0 0 38.53 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 215μs 206ns 797ns 0.523 0 0 38.6 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 265μs 849ns 3.29μs 6.16 0.513 0 39.2 KB
#4906 RunWaf(args=NestedMap (10)) net6.0 52.2μs 19.4ns 69.8ns 0.209 0 0 16.06 KB
#4906 RunWaf(args=NestedMap (10)) netcoreapp3.1 65.1μs 211ns 761ns 0.196 0 0 16.06 KB
#4906 RunWaf(args=NestedMap (10)) net472 93.5μs 32.2ns 125ns 2.53 0.0936 0 16.14 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 120μs 578ns 2.45μs 0.29 0 0 22.41 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 137μs 737ns 3.97μs 0.264 0 0 22.36 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [22]) net472 167μs 98.7ns 382ns 3.58 0.167 0 22.7 KB
#4906 RunWaf(args=NestedMap (100)) net6.0 105μs 503ns 1.95μs 0.468 0 0 32.76 KB
#4906 RunWaf(args=NestedMap (100)) netcoreapp3.1 135μs 640ns 2.48μs 0.405 0 0 33.33 KB
#4906 RunWaf(args=NestedMap (100)) net472 183μs 103ns 400ns 5.27 0.37 0 33.67 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 174μs 65ns 252ns 0.521 0 0 39.1 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 205μs 518ns 1.94μs 0.508 0 0 39.63 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [23]) net472 270μs 192ns 717ns 6.39 0.522 0 40.23 KB
#4906 RunWaf(args=NestedMap (20)) net6.0 96.2μs 39.6ns 173ns 0.436 0 0 32.18 KB
#4906 RunWaf(args=NestedMap (20)) netcoreapp3.1 129μs 689ns 3.77μs 0.375 0 0 32.3 KB
#4906 RunWaf(args=NestedMap (20)) net472 188μs 101ns 389ns 5.16 0.362 0 32.63 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 162μs 61.2ns 229ns 0.496 0 0 38.53 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 213μs 472ns 1.83μs 0.511 0 0 38.6 KB
#4906 RunWafWithAttack(args=Neste(...)tack) [22]) net472 260μs 88ns 341ns 6.12 0.521 0 39.2 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 175μs 205ns 793ns 0.175 0 0 18.25 KB
master SendRequest netcoreapp3.1 191μs 423ns 1.64μs 0.19 0 0 20.41 KB
master SendRequest net472 0.00148ns 0.000362ns 0.0014ns 0 0 0 0 b
#4906 SendRequest net6.0 175μs 166ns 644ns 0.175 0 0 18.25 KB
#4906 SendRequest netcoreapp3.1 191μs 290ns 1.12μs 0.19 0 0 20.41 KB
#4906 SendRequest net472 0.00152ns 0.000317ns 0.00123ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 544μs 617ns 2.31μs 0.556 0 0 41.51 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 586ns 2.27μs 0.327 0 0 41.92 KB
master WriteAndFlushEnrichedTraces net472 854μs 4.13μs 16.5μs 8.13 2.57 0.428 53.22 KB
#4906 WriteAndFlushEnrichedTraces net6.0 549μs 899ns 3.24μs 0.566 0 0 41.67 KB
#4906 WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 1.21μs 4.67μs 0.322 0 0 41.74 KB
#4906 WriteAndFlushEnrichedTraces net472 824μs 3.15μs 12.2μs 8.45 2.53 0.422 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.01μs 0.427ns 1.65ns 0.0106 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.47μs 0.595ns 2.3ns 0.0102 0 0 768 B
master ExecuteNonQuery net472 1.79μs 3.66ns 14.2ns 0.116 0 0 730 B
#4906 ExecuteNonQuery net6.0 1.11μs 2.33ns 8.73ns 0.0105 0 0 768 B
#4906 ExecuteNonQuery netcoreapp3.1 1.4μs 0.967ns 3.49ns 0.0105 0 0 768 B
#4906 ExecuteNonQuery net472 1.77μs 0.985ns 3.81ns 0.115 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.865ns 3.24ns 0.0135 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.942ns 3.52ns 0.0131 0 0 936 B
master CallElasticsearch net472 2.51μs 0.596ns 2.23ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.24μs 0.521ns 2.02ns 0.013 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.349ns 1.31ns 0.013 0 0 984 B
master CallElasticsearchAsync net472 2.67μs 1.58ns 6.11ns 0.16 0 0 1.01 KB
#4906 CallElasticsearch net6.0 1.17μs 1.01ns 3.92ns 0.0129 0 0 936 B
#4906 CallElasticsearch netcoreapp3.1 1.47μs 0.532ns 1.99ns 0.0126 0 0 936 B
#4906 CallElasticsearch net472 2.5μs 0.751ns 2.91ns 0.151 0 0 955 B
#4906 CallElasticsearchAsync net6.0 1.26μs 0.586ns 2.19ns 0.0122 0 0 912 B
#4906 CallElasticsearchAsync netcoreapp3.1 1.65μs 3.64ns 13.6ns 0.0134 0 0 984 B
#4906 CallElasticsearchAsync net472 2.61μs 1.65ns 6.39ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.29μs 1.51ns 5.85ns 0.0124 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.761ns 2.85ns 0.012 0 0 912 B
master ExecuteAsync net472 1.81μs 1.15ns 4.45ns 0.139 0 0 875 B
#4906 ExecuteAsync net6.0 1.43μs 1.65ns 5.96ns 0.0128 0 0 912 B
#4906 ExecuteAsync netcoreapp3.1 1.57μs 1.15ns 4.29ns 0.0118 0 0 912 B
#4906 ExecuteAsync net472 1.77μs 0.568ns 2.2ns 0.139 0.000888 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.12μs 6.68ns 25ns 0.0287 0 0 2.1 KB
master SendAsync netcoreapp3.1 4.83μs 2.11ns 8.17ns 0.0363 0 0 2.63 KB
master SendAsync net472 7.82μs 2.5ns 9.35ns 0.522 0 0 3.31 KB
#4906 SendAsync net6.0 4.16μs 1.91ns 7.13ns 0.0292 0 0 2.1 KB
#4906 SendAsync netcoreapp3.1 4.99μs 1.56ns 5.84ns 0.0348 0 0 2.63 KB
#4906 SendAsync net472 7.68μs 2.11ns 7.91ns 0.523 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 Fewer allocations 🎉

Faster 🎉 in #4906

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net6.0 1.181 60,750.00 51,450.00 multimodal

Fewer allocations 🎉 in #4906

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 60.4μs 777ns 7.77μs 0 0 0 43.44 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 57.5μs 738ns 7.12μs 0 0 0 42.64 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 37.8μs 96.9ns 363ns 0 0 0 59.66 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 65.2μs 319ns 1.31μs 0 0 0 43.29 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 97.9μs 3.06μs 30.6μs 0 0 0 42.64 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 57.3μs 902ns 8.84μs 0 0 0 65.54 KB
#4906 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 51.8μs 268ns 1.2μs 0 0 0 43.44 KB
#4906 StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 63.9μs 961ns 9.41μs 0 0 0 42.64 KB
#4906 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 38.2μs 117ns 405ns 0 0 0 59.77 KB
#4906 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 65.4μs 324ns 1.34μs 0 0 0 43.29 KB
#4906 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 91.7μs 3.67μs 36.5μs 0 0 0 42.64 KB
#4906 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 63.8μs 328ns 1.61μs 0 0 0 57.34 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.591ns 2.29ns 0.0221 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 2.17μs 0.943ns 3.53ns 0.0208 0 0 1.57 KB
master EnrichedLog net472 2.66μs 1.07ns 3.85ns 0.238 0 0 1.5 KB
#4906 EnrichedLog net6.0 1.44μs 0.815ns 3.16ns 0.0224 0 0 1.57 KB
#4906 EnrichedLog netcoreapp3.1 2.11μs 1.03ns 3.85ns 0.0219 0 0 1.57 KB
#4906 EnrichedLog net472 2.57μs 3.26ns 11.7ns 0.238 0 0 1.5 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 140ns 542ns 0.0563 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 119μs 296ns 1.15μs 0.0587 0 0 4.21 KB
master EnrichedLog net472 149μs 277ns 1.07μs 0.667 0.222 0 4.39 KB
#4906 EnrichedLog net6.0 114μs 143ns 555ns 0.0568 0 0 4.21 KB
#4906 EnrichedLog netcoreapp3.1 118μs 205ns 796ns 0 0 0 4.21 KB
#4906 EnrichedLog net472 152μs 61ns 228ns 0.682 0.227 0 4.39 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.03μs 1.11ns 4.28ns 0.0288 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 4.13μs 1.76ns 6.81ns 0.0288 0 0 2.13 KB
master EnrichedLog net472 4.89μs 3.71ns 14.4ns 0.308 0 0 1.95 KB
#4906 EnrichedLog net6.0 2.98μs 1.16ns 4.33ns 0.0298 0 0 2.13 KB
#4906 EnrichedLog netcoreapp3.1 4.4μs 4.6ns 17.8ns 0.0285 0 0 2.13 KB
#4906 EnrichedLog net472 5.1μs 3.99ns 15.4ns 0.307 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 0.84ns 3.14ns 0.0158 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.78μs 0.908ns 3.52ns 0.0152 0 0 1.1 KB
master SendReceive net472 2.01μs 1.22ns 4.72ns 0.177 0 0 1.12 KB
#4906 SendReceive net6.0 1.36μs 0.851ns 3.29ns 0.0156 0 0 1.1 KB
#4906 SendReceive netcoreapp3.1 1.78μs 0.585ns 2.27ns 0.015 0 0 1.1 KB
#4906 SendReceive net472 2.17μs 1.68ns 5.82ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 3.2ns 12.4ns 0.0204 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.87μs 1.41ns 4.89ns 0.0214 0 0 1.58 KB
master EnrichedLog net472 4.33μs 1.26ns 4.87ns 0.312 0 0 1.97 KB
#4906 EnrichedLog net6.0 2.68μs 0.692ns 2.49ns 0.0215 0 0 1.53 KB
#4906 EnrichedLog netcoreapp3.1 3.93μs 1.37ns 5.12ns 0.0197 0 0 1.58 KB
#4906 EnrichedLog net472 4.41μs 2.87ns 11.1ns 0.311 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 461ns 0.401ns 1.55ns 0.00759 0 0 536 B
master StartFinishSpan netcoreapp3.1 694ns 0.455ns 1.64ns 0.00704 0 0 536 B
master StartFinishSpan net472 728ns 0.915ns 3.42ns 0.0854 0 0 538 B
master StartFinishScope net6.0 572ns 0.705ns 2.73ns 0.00908 0 0 656 B
master StartFinishScope netcoreapp3.1 857ns 0.47ns 1.82ns 0.00864 0 0 656 B
master StartFinishScope net472 1.05μs 1.32ns 5.09ns 0.0977 0 0 618 B
#4906 StartFinishSpan net6.0 454ns 0.157ns 0.608ns 0.00751 0 0 536 B
#4906 StartFinishSpan netcoreapp3.1 669ns 1.19ns 4.47ns 0.007 0 0 536 B
#4906 StartFinishSpan net472 714ns 0.291ns 1.13ns 0.0853 0 0 538 B
#4906 StartFinishScope net6.0 614ns 0.474ns 1.71ns 0.00898 0 0 656 B
#4906 StartFinishScope netcoreapp3.1 810ns 0.635ns 2.46ns 0.00887 0 0 656 B
#4906 StartFinishScope net472 1.02μs 0.585ns 2.27ns 0.098 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4906

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.294 834.89 645.25

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 836ns 1.11ns 4.3ns 0.00929 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 988ns 0.798ns 3.09ns 0.00908 0 0 656 B
master RunOnMethodBegin net472 1.16μs 1.24ns 4.81ns 0.098 0 0 618 B
#4906 RunOnMethodBegin net6.0 645ns 0.166ns 0.621ns 0.00907 0 0 656 B
#4906 RunOnMethodBegin netcoreapp3.1 997ns 0.353ns 1.32ns 0.00889 0 0 656 B
#4906 RunOnMethodBegin net472 1.14μs 0.286ns 1.11ns 0.0979 0 0 618 B

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 30, 2023 •
edited
Loading

Datadog Report

Branch report: kevin/artifacts_dumps
Commit report: c838d83

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 300322 Passed, 951 Skipped, 46m 37.34s Wall Time

@kevingosse kevingosse merged commit 924dc94 into master Dec 1, 2023
54 checks passed
@kevingosse kevingosse deleted the kevin/artifacts_dumps branch December 1, 2023 10:04
@github-actions github-actions bot added this to the vNext milestone Dec 1, 2023
@kevingosse kevingosse mentioned this pull request Dec 1, 2023
Merged
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
2.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kevingosse @andrewlock