Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test environment variable in Samples.Console #4948

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove test environment variable in Samples.Console #4948

merged 1 commit into from
Dec 6, 2023

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Remove a test that was introduced in #4906 (but forgot to cleanup)

@kevingosse kevingosse requested a review from a team as a code owner December 1, 2023 16:58
@github-actions github-actions bot added the area:tests unit tests, integration tests label Dec 1, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 1, 2023 •
edited
Loading

Datadog Report

Branch report: kevin/dd-dotnet-cleanup
Commit report: 84fae18

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 301553 Passed, 1025 Skipped, 54m 10.75s Wall Time

@andrewlock
Copy link
Member

andrewlock commented Dec 1, 2023 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4948) - mean (72ms)  : 59, 85
     .   : milestone, 72,
    master - mean (71ms)  : 62, 81
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4948) - mean (1,000ms)  : 978, 1022
     .   : milestone, 1000,
    master - mean (996ms)  : 972, 1020
     .   : milestone, 996,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4948) - mean (106ms)  : 101, 111
     .   : milestone, 106,
    master - mean (106ms)  : 103, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4948) - mean (692ms)  : 667, 717
     .   : milestone, 692,
    master - mean (689ms)  : 669, 710
     .   : milestone, 689,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4948) - mean (90ms)  : 86, 94
     .   : milestone, 90,
    master - mean (89ms)  : 85, 94
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4948) - mean (660ms)  : 632, 688
     .   : milestone, 660,
    master - mean (660ms)  : 636, 684
     .   : milestone, 660,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4948) - mean (189ms)  : 187, 191
     .   : milestone, 189,
    master - mean (189ms)  : 185, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4948) - mean (1,135ms)  : 1116, 1154
     .   : milestone, 1135,
    master - mean (1,134ms)  : 1110, 1158
     .   : milestone, 1134,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4948) - mean (272ms)  : 269, 276
     .   : milestone, 272,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4948) - mean (1,096ms)  : 1065, 1127
     .   : milestone, 1096,
    master - mean (1,087ms)  : 1063, 1111
     .   : milestone, 1087,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4948) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4948) - mean (1,059ms)  : 1035, 1083
     .   : milestone, 1059,
    master - mean (1,066ms)  : 1041, 1091
     .   : milestone, 1066,
Loading

@andrewlock
Copy link
Member

andrewlock commented Dec 1, 2023 •
edited
Loading

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4948) (11.268M)   : 0, 11268353
    master (11.422M)   : 0, 11422363
    benchmarks/2.9.0 (11.109M)   : 0, 11108980

    section Automatic
    This PR (4948) (7.863M)   : 0, 7862644
    master (7.718M)   : 0, 7718112
    benchmarks/2.9.0 (8.083M)   : 0, 8082605

    section Trace stats
    This PR (4948) (8.064M)   : 0, 8063622
    master (8.043M)   : 0, 8042702

    section Manual
    This PR (4948) (10.060M)   : 0, 10059937
    master (10.053M)   : 0, 10053065

    section Manual + Automatic
    This PR (4948) (7.309M)   : 0, 7308608
    master (7.498M)   : 0, 7498064

    section Version Conflict
    This PR (4948) (6.580M)   : 0, 6579588
    master (6.744M)   : 0, 6743718
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4948) (9.518M)   : 0, 9518260
    master (9.441M)   : 0, 9441426
    benchmarks/2.9.0 (9.303M)   : 0, 9302781

    section Automatic
    This PR (4948) (6.609M)   : 0, 6609385
    master (6.464M)   : 0, 6463674

    section Trace stats
    This PR (4948) (6.835M)   : 0, 6834508
    master (6.869M)   : 0, 6869265

    section Manual
    This PR (4948) (8.213M)   : 0, 8213086
    master (8.253M)   : 0, 8253313

    section Manual + Automatic
    This PR (4948) (6.191M)   : 0, 6190919
    master (6.141M)   : 0, 6140717

    section Version Conflict
    This PR (4948) (5.744M)   : 0, 5743570
    master (5.692M)   : 0, 5691697
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4948) (10.424M)   : 0, 10424253
    master (10.722M)   : 0, 10722051
    benchmarks/2.9.0 (11.129M)   : 0, 11128978

    section Automatic
    This PR (4948) (7.535M)   : 0, 7534968
    master (7.482M)   : 0, 7481918
    benchmarks/2.9.0 (8.109M)   : 0, 8108685

    section Trace stats
    This PR (4948) (7.812M)   : 0, 7812214
    master (7.894M)   : 0, 7893943

    section Manual
    This PR (4948) (9.277M)   : 0, 9276566
    master (9.471M)   : 0, 9471155

    section Manual + Automatic
    This PR (4948) (7.246M)   : 0, 7246099
    master (7.169M)   : 0, 7169035

    section Version Conflict
    This PR (4948) (6.636M)   : 0, 6635696
    master (6.495M)   : 0, 6494592
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.523M)   : 0, 7523483
    benchmarks/2.9.0 (7.724M)   : 0, 7724099

    section No attack
    master (1.964M)   : 0, 1963791
    benchmarks/2.9.0 (3.167M)   : 0, 3166743

    section Attack
    master (1.574M)   : 0, 1574342
    benchmarks/2.9.0 (2.437M)   : 0, 2436746

    section Blocking
    master (3.240M)   : 0, 3239829

    section IAST default
    master (6.486M)   : 0, 6485841

    section IAST full
    master (5.855M)   : 0, 5855390

    section Base vuln
    master (0.955M)   : 0, 954653

    section IAST vuln
    master (0.859M)   : 0, 858537
Loading

@andrewlock
Copy link
Member

andrewlock commented Dec 1, 2023 •
edited
Loading

Benchmarks Report 🐌

Benchmarks for #4948 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.158
  • 2 benchmarks are slower, with geometric mean 1.152
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.78μs 48.3ns 282ns 0.0214 0.00856 0 7.48 KB
master StartStopWithChild netcoreapp3.1 10.9μs 56.9ns 273ns 0.0215 0.00538 0 7.58 KB
master StartStopWithChild net472 17.1μs 64.6ns 250ns 1.35 0.349 0.111 7.95 KB
#4948 StartStopWithChild net6.0 8.56μs 47.8ns 306ns 0.0205 0.00819 0 7.48 KB
#4948 StartStopWithChild netcoreapp3.1 10.7μs 54.3ns 237ns 0.0257 0.0103 0 7.57 KB
#4948 StartStopWithChild net472 17μs 33.1ns 128ns 1.32 0.332 0.0937 7.95 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 476μs 293ns 1.13μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 258ns 1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 789μs 240ns 929ns 0.398 0 0 3.3 KB
#4948 WriteAndFlushEnrichedTraces net6.0 463μs 487ns 1.89μs 0 0 0 2.7 KB
#4948 WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 132ns 493ns 0 0 0 2.7 KB
#4948 WriteAndFlushEnrichedTraces net472 777μs 329ns 1.27μs 0.386 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 43.9μs 35ns 136ns 0.0221 0 0 1.77 KB
master AllCycleSimpleBody netcoreapp3.1 46.8μs 38.2ns 138ns 0.0233 0 0 1.74 KB
master AllCycleSimpleBody net472 49.3μs 121ns 468ns 0.269 0 0 1.81 KB
master AllCycleMoreComplexBody net6.0 215μs 171ns 661ns 0.106 0 0 9.25 KB
master AllCycleMoreComplexBody netcoreapp3.1 226μs 289ns 1.26μs 0.113 0 0 9.14 KB
master AllCycleMoreComplexBody net472 237μs 94.1ns 365ns 1.42 0 0 9.32 KB
master ObjectExtractorSimpleBody net6.0 134ns 0.0414ns 0.155ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 194ns 0.228ns 0.852ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 153ns 0.0718ns 0.269ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.86μs 1.65ns 6.17ns 0.053 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.62μs 1.45ns 5.42ns 0.0506 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.51μs 2.78ns 10.8ns 0.602 0.00525 0 3.8 KB
#4948 AllCycleSimpleBody net6.0 44.2μs 43.7ns 169ns 0.0221 0 0 1.77 KB
#4948 AllCycleSimpleBody netcoreapp3.1 47.3μs 17.7ns 66.2ns 0.0238 0 0 1.74 KB
#4948 AllCycleSimpleBody net472 49.3μs 142ns 549ns 0.266 0 0 1.81 KB
#4948 AllCycleMoreComplexBody net6.0 212μs 58.5ns 219ns 0.106 0 0 9.25 KB
#4948 AllCycleMoreComplexBody netcoreapp3.1 225μs 239ns 927ns 0.112 0 0 9.14 KB
#4948 AllCycleMoreComplexBody net472 240μs 135ns 524ns 1.43 0 0 9.32 KB
#4948 ObjectExtractorSimpleBody net6.0 133ns 0.04ns 0.15ns 0.00392 0 0 280 B
#4948 ObjectExtractorSimpleBody netcoreapp3.1 182ns 0.0768ns 0.287ns 0.00368 0 0 272 B
#4948 ObjectExtractorSimpleBody net472 153ns 0.515ns 1.99ns 0.0446 0 0 281 B
#4948 ObjectExtractorMoreComplexBody net6.0 2.83μs 1.95ns 7.53ns 0.0522 0 0 3.78 KB
#4948 ObjectExtractorMoreComplexBody netcoreapp3.1 3.59μs 1.43ns 5.37ns 0.0502 0 0 3.69 KB
#4948 ObjectExtractorMoreComplexBody net472 3.5μs 1.2ns 4.16ns 0.603 0.00521 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 53.7μs 81.1ns 303ns 0.214 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 68.9μs 371ns 1.96μs 0.202 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) net472 93.8μs 53.6ns 208ns 2.53 0.0938 0 16.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 115μs 97ns 423ns 0.304 0 0 22.41 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 137μs 254ns 985ns 0.281 0 0 22.36 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 165μs 97.8ns 353ns 3.54 0.165 0 22.7 KB
master RunWaf(args=NestedMap (100)) net6.0 104μs 472ns 1.83μs 0.428 0 0 32.76 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 131μs 463ns 1.73μs 0.395 0 0 33.33 KB
master RunWaf(args=NestedMap (100)) net472 189μs 911ns 3.64μs 5.28 0.364 0 33.67 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 175μs 618ns 2.39μs 0.49 0 0 39.1 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 206μs 811ns 2.92μs 0.511 0 0 39.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 266μs 1.29μs 5.17μs 6.31 0.515 0 40.23 KB
master RunWaf(args=NestedMap (20)) net6.0 93.9μs 34.6ns 120ns 0.423 0 0 32.18 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 129μs 708ns 4.25μs 0.398 0 0 32.3 KB
master RunWaf(args=NestedMap (20)) net472 192μs 581ns 2.25μs 5.18 0.363 0 32.63 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 172μs 85.9ns 333ns 0.517 0 0 38.53 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 199μs 113ns 391ns 0.52 0 0 38.6 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 266μs 738ns 2.86μs 6.17 0.514 0 39.2 KB
#4948 RunWaf(args=NestedMap (10)) net6.0 49.6μs 252ns 1.1μs 0.219 0 0 16.06 KB
#4948 RunWaf(args=NestedMap (10)) netcoreapp3.1 70.7μs 349ns 1.56μs 0.209 0 0 16.06 KB
#4948 RunWaf(args=NestedMap (10)) net472 93.5μs 54.5ns 211ns 2.52 0.0934 0 16.14 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 117μs 530ns 2.05μs 0.294 0 0 22.41 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 135μs 665ns 2.82μs 0.272 0 0 22.36 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [22]) net472 171μs 59.1ns 221ns 3.54 0.165 0 22.7 KB
#4948 RunWaf(args=NestedMap (100)) net6.0 102μs 536ns 2.73μs 0.431 0 0 32.76 KB
#4948 RunWaf(args=NestedMap (100)) netcoreapp3.1 135μs 630ns 2.6μs 0.443 0 0 33.33 KB
#4948 RunWaf(args=NestedMap (100)) net472 190μs 101ns 378ns 5.32 0.367 0 33.67 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 174μs 894ns 4μs 0.566 0 0 39.1 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 212μs 985ns 3.82μs 0.506 0 0 39.63 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [23]) net472 262μs 360ns 1.39μs 6.38 0.521 0 40.23 KB
#4948 RunWaf(args=NestedMap (20)) net6.0 101μs 545ns 2.94μs 0.447 0 0 32.18 KB
#4948 RunWaf(args=NestedMap (20)) netcoreapp3.1 136μs 467ns 1.81μs 0.389 0 0 32.3 KB
#4948 RunWaf(args=NestedMap (20)) net472 183μs 281ns 1.09μs 5.16 0.362 0 32.63 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 172μs 585ns 2.87μs 0.515 0 0 38.53 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 206μs 1μs 4.01μs 0.524 0 0 38.6 KB
#4948 RunWafWithAttack(args=Neste(...)tack) [22]) net472 264μs 105ns 392ns 6.15 0.523 0 39.2 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 174μs 181ns 676ns 0.173 0 0 18.25 KB
master SendRequest netcoreapp3.1 195μs 404ns 1.56μs 0.195 0 0 20.41 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#4948 SendRequest net6.0 172μs 192ns 744ns 0.172 0 0 18.25 KB
#4948 SendRequest netcoreapp3.1 191μs 272ns 1.05μs 0.191 0 0 20.41 KB
#4948 SendRequest net472 0.000267ns 0.000125ns 0.000452ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4948

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.41 KB 41.79 KB 378 B 0.91%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 547μs 828ns 3.21μs 0.553 0 0 41.41 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 530ns 2.05μs 0.324 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 810μs 3.33μs 12.9μs 8.31 2.37 0.396 53.24 KB
#4948 WriteAndFlushEnrichedTraces net6.0 551μs 1.81μs 7.03μs 0.541 0 0 41.79 KB
#4948 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 2.18μs 8.45μs 0.324 0 0 41.75 KB
#4948 WriteAndFlushEnrichedTraces net472 795μs 3.11μs 12.8μs 8.31 2.37 0.396 53.22 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4948

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.171 1,109.16 947.07

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.11μs 0.785ns 3.04ns 0.0105 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.55μs 0.632ns 2.45ns 0.0101 0 0 768 B
master ExecuteNonQuery net472 1.81μs 0.748ns 2.9ns 0.116 0 0 730 B
#4948 ExecuteNonQuery net6.0 947ns 0.393ns 1.52ns 0.0109 0 0 768 B
#4948 ExecuteNonQuery netcoreapp3.1 1.4μs 4.73ns 18.3ns 0.0104 0 0 768 B
#4948 ExecuteNonQuery net472 1.83μs 0.729ns 2.73ns 0.116 0.000912 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4948

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.183 1,348.14 1,139.65

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 0.427ns 1.6ns 0.013 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.58μs 1.14ns 4.28ns 0.0124 0 0 936 B
master CallElasticsearch net472 2.51μs 1.07ns 4.16ns 0.152 0 0 955 B
master CallElasticsearchAsync net6.0 1.35μs 0.499ns 1.93ns 0.0128 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 2.04ns 7.9ns 0.0132 0 0 984 B
master CallElasticsearchAsync net472 2.58μs 0.779ns 3.02ns 0.16 0 0 1.01 KB
#4948 CallElasticsearch net6.0 1.19μs 0.676ns 2.53ns 0.0132 0 0 936 B
#4948 CallElasticsearch netcoreapp3.1 1.51μs 1.09ns 4.06ns 0.0127 0 0 936 B
#4948 CallElasticsearch net472 2.44μs 0.455ns 1.7ns 0.152 0 0 955 B
#4948 CallElasticsearchAsync net6.0 1.14μs 0.428ns 1.6ns 0.0125 0 0 912 B
#4948 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.763ns 2.85ns 0.0133 0 0 984 B
#4948 CallElasticsearchAsync net472 2.73μs 0.925ns 3.58ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.36μs 1.4ns 5.42ns 0.0128 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.67μs 0.716ns 2.58ns 0.0126 0 0 912 B
master ExecuteAsync net472 1.86μs 0.736ns 2.76ns 0.139 0 0 875 B
#4948 ExecuteAsync net6.0 1.25μs 1.03ns 4ns 0.0126 0 0 912 B
#4948 ExecuteAsync netcoreapp3.1 1.66μs 1.17ns 4.38ns 0.0123 0 0 912 B
#4948 ExecuteAsync net472 1.8μs 0.708ns 2.65ns 0.138 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.12μs 1.98ns 7.4ns 0.0288 0 0 2.1 KB
master SendAsync netcoreapp3.1 4.9μs 3.35ns 13ns 0.0344 0 0 2.63 KB
master SendAsync net472 7.75μs 4.8ns 18.6ns 0.523 0 0 3.31 KB
#4948 SendAsync net6.0 4.04μs 2.55ns 9.55ns 0.0302 0 0 2.1 KB
#4948 SendAsync netcoreapp3.1 4.9μs 2.33ns 8.39ns 0.0341 0 0 2.63 KB
#4948 SendAsync net472 7.88μs 3.61ns 14ns 0.525 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4948

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net472 60.02 KB 59.7 KB -320 B -0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 59μs 485ns 4.58μs 0 0 0 43.44 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 52.8μs 258ns 1.1μs 0 0 0 42.64 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 38.4μs 65.7ns 228ns 0 0 0 60.02 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 66.8μs 263ns 983ns 0 0 0 43.29 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 95.6μs 3.94μs 39.2μs 0 0 0 42.64 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 63.7μs 316ns 1.45μs 0 0 0 57.34 KB
#4948 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 59.9μs 826ns 8.13μs 0 0 0 43.44 KB
#4948 StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 52.9μs 279ns 1.4μs 0 0 0 42.64 KB
#4948 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 38.3μs 123ns 444ns 0 0 0 59.7 KB
#4948 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 65.8μs 300ns 1.16μs 0 0 0 43.29 KB
#4948 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 106μs 3.04μs 30.4μs 0 0 0 42.64 KB
#4948 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 63.7μs 168ns 651ns 0 0 0 57.34 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4948

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.122 1,630.25 1,452.83

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.63μs 0.827ns 2.98ns 0.022 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 2.07μs 0.954ns 3.57ns 0.0208 0 0 1.57 KB
master EnrichedLog net472 2.75μs 2.92ns 11.3ns 0.237 0 0 1.5 KB
#4948 EnrichedLog net6.0 1.45μs 0.894ns 3.35ns 0.0218 0 0 1.57 KB
#4948 EnrichedLog netcoreapp3.1 2.24μs 0.494ns 1.91ns 0.0212 0 0 1.57 KB
#4948 EnrichedLog net472 2.54μs 3.52ns 13.6ns 0.238 0 0 1.5 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 133ns 514ns 0.0583 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 119μs 149ns 577ns 0.0591 0 0 4.21 KB
master EnrichedLog net472 146μs 49.3ns 171ns 0.658 0.219 0 4.39 KB
#4948 EnrichedLog net6.0 114μs 77.2ns 289ns 0.056 0 0 4.21 KB
#4948 EnrichedLog netcoreapp3.1 117μs 78.6ns 305ns 0.0586 0 0 4.21 KB
#4948 EnrichedLog net472 147μs 48.2ns 174ns 0.663 0.221 0 4.39 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 1.44ns 5.57ns 0.0299 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 4.34μs 1.48ns 5.73ns 0.0282 0 0 2.13 KB
master EnrichedLog net472 4.94μs 3.34ns 12.9ns 0.307 0 0 1.95 KB
#4948 EnrichedLog net6.0 3.01μs 1.58ns 5.92ns 0.0301 0 0 2.13 KB
#4948 EnrichedLog netcoreapp3.1 4.17μs 2.53ns 9.45ns 0.0291 0 0 2.13 KB
#4948 EnrichedLog net472 5μs 3.95ns 15.3ns 0.309 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.27μs 0.735ns 2.85ns 0.0151 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.77μs 3.93ns 15.2ns 0.0147 0 0 1.1 KB
master SendReceive net472 2.14μs 1.29ns 4.82ns 0.177 0 0 1.12 KB
#4948 SendReceive net6.0 1.34μs 1.21ns 4.52ns 0.0156 0 0 1.1 KB
#4948 SendReceive netcoreapp3.1 1.72μs 1.04ns 3.88ns 0.0146 0 0 1.1 KB
#4948 SendReceive net472 2.09μs 1.43ns 5.56ns 0.176 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.76μs 1.15ns 4.3ns 0.0207 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.99μs 0.937ns 3.63ns 0.02 0 0 1.58 KB
master EnrichedLog net472 4.28μs 1.71ns 6.64ns 0.311 0 0 1.97 KB
#4948 EnrichedLog net6.0 2.82μs 1.13ns 4.36ns 0.0211 0 0 1.53 KB
#4948 EnrichedLog netcoreapp3.1 3.92μs 1.52ns 5.69ns 0.0214 0 0 1.58 KB
#4948 EnrichedLog net472 4.24μs 1.18ns 4.4ns 0.311 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4948

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.165 450.42 524.78

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 450ns 0.129ns 0.483ns 0.00759 0 0 536 B
master StartFinishSpan netcoreapp3.1 781ns 1.64ns 6.37ns 0.0073 0 0 536 B
master StartFinishSpan net472 765ns 0.165ns 0.616ns 0.0853 0 0 538 B
master StartFinishScope net6.0 515ns 0.145ns 0.543ns 0.00908 0 0 656 B
master StartFinishScope netcoreapp3.1 818ns 0.436ns 1.57ns 0.00896 0 0 656 B
master StartFinishScope net472 928ns 0.258ns 1ns 0.0982 0 0 618 B
#4948 StartFinishSpan net6.0 525ns 0.238ns 0.923ns 0.00752 0 0 536 B
#4948 StartFinishSpan netcoreapp3.1 781ns 0.2ns 0.72ns 0.00702 0 0 536 B
#4948 StartFinishSpan net472 796ns 0.196ns 0.758ns 0.0853 0 0 538 B
#4948 StartFinishScope net6.0 520ns 0.17ns 0.659ns 0.00919 0 0 656 B
#4948 StartFinishScope netcoreapp3.1 854ns 0.333ns 1.29ns 0.00899 0 0 656 B
#4948 StartFinishScope net472 904ns 0.632ns 2.45ns 0.0979 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4948

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.138 591.38 673.08

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 590ns 0.645ns 2.5ns 0.00911 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 931ns 1.02ns 3.93ns 0.00873 0 0 656 B
master RunOnMethodBegin net472 1.08μs 0.321ns 1.24ns 0.0981 0 0 618 B
#4948 RunOnMethodBegin net6.0 674ns 0.342ns 1.32ns 0.00911 0 0 656 B
#4948 RunOnMethodBegin netcoreapp3.1 883ns 0.299ns 1.16ns 0.00882 0 0 656 B
#4948 RunOnMethodBegin net472 1.17μs 0.803ns 3.11ns 0.0976 0 0 618 B

@kevingosse kevingosse merged commit b6b473d into master Dec 6, 2023
54 checks passed
@kevingosse kevingosse deleted the kevin/dd-dotnet-cleanup branch December 6, 2023 09:41
@github-actions github-actions bot added this to the vNext milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
2.44.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kevingosse @andrewlock @bouwkast