[Dynamic Instrumentation] Check specific path for diagnostics upload #5461

shurivich · 2024-04-18T08:37:57Z

Summary of changes

Send by default for the updated endpoint, instead of legacy.
Better path checking for legacy

Reason for change

Comment resolve for #5456 (comment)

datadog-ddstaging · 2024-04-18T09:01:00Z

Datadog Report

Branch report: shurivich/legacy_endpoint
Commit report: a5cac62
Test service: dd-trace-dotnet

✅ 0 Failed, 331770 Passed, 2004 Skipped, 41m 41.53s Wall Time

tracer/src/Datadog.Trace/Debugger/Upload/DiagnosticsUploadApi.cs

andrewlock · 2024-04-18T09:10:58Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5461) - mean (73ms)  : 64, 82
     .   : milestone, 73,
    master - mean (74ms)  : 64, 84
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5461) - mean (997ms)  : 962, 1031
     .   : milestone, 997,
    master - mean (1,016ms)  : 984, 1047
     .   : milestone, 1016,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5461) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (113ms)  : 109, 116
     .   : milestone, 113,

    section CallTarget+Inlining+NGEN
    This PR (5461) - mean (719ms)  : 692, 747
     .   : milestone, 719,
    master - mean (742ms)  : 713, 771
     .   : milestone, 742,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5461) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5461) - mean (673ms)  : 640, 706
     .   : milestone, 673,
    master - mean (669ms)  : 644, 695
     .   : milestone, 669,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5461) - mean (193ms)  : 189, 196
     .   : milestone, 193,
    master - mean (192ms)  : 189, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5461) - mean (1,108ms)  : 1089, 1127
     .   : milestone, 1108,
    master - mean (1,098ms)  : 1074, 1122
     .   : milestone, 1098,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5461) - mean (277ms)  : 272, 283
     .   : milestone, 277,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5461) - mean (903ms)  : 882, 924
     .   : milestone, 903,
    master - mean (903ms)  : 881, 925
     .   : milestone, 903,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5461) - mean (268ms)  : 262, 273
     .   : milestone, 268,
    master - mean (267ms)  : 261, 273
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (5461) - mean (888ms)  : 863, 913
     .   : milestone, 888,
    master - mean (887ms)  : 858, 916
     .   : milestone, 887,

andrewlock · 2024-04-18T09:23:28Z

Benchmarks Report for tracer 🐌

Benchmarks for #5461 compared to master:

1 benchmarks are faster, with geometric mean 1.139
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.81μs	48.1ns	280ns	0.0277	0.0138	0	7.55 KB
master	`StartStopWithChild`	netcoreapp3.1	10.9μs	57.5ns	287ns	0.0275	0.011	0	7.65 KB
master	`StartStopWithChild`	net472	17.1μs	38.7ns	150ns	1.37	0.391	0.122	8.06 KB
#5461	`StartStopWithChild`	net6.0	8.45μs	35.2ns	132ns	0.0208	0.00831	0	7.55 KB
#5461	`StartStopWithChild`	netcoreapp3.1	10.8μs	56.7ns	300ns	0.0259	0.0155	0	7.65 KB
#5461	`StartStopWithChild`	net472	17μs	50.9ns	197ns	1.35	0.375	0.111	8.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	465μs	297ns	1.11μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	131ns	490ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	837μs	180ns	625ns	0.417	3.3 KB
#5461	`WriteAndFlushEnrichedTraces`	net6.0	496μs	215ns	833ns	0	2.7 KB
#5461	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	239ns	926ns	0	2.7 KB
#5461	`WriteAndFlushEnrichedTraces`	net472	834μs	315ns	1.22μs	0.414	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	173μs	214ns	830ns	0.17	18.44 KB
master	`SendRequest`	netcoreapp3.1	192μs	243ns	942ns	0.193	20.6 KB
master	`SendRequest`	net472	0.000127ns	0.000109ns	0.000394ns	0	0 b
#5461	`SendRequest`	net6.0	170μs	265ns	1.03μs	0.17	18.44 KB
#5461	`SendRequest`	netcoreapp3.1	191μs	303ns	1.14μs	0.193	20.6 KB
#5461	`SendRequest`	net472	0.143ns	0.000878ns	0.0034ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5461

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.56 KB	41.88 KB	319 B	0.77%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	591μs	1.21μs	4.69μs	0.587	0	0	41.56 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	910ns	3.41μs	0.329	0	0	41.82 KB
master	`WriteAndFlushEnrichedTraces`	net472	830μs	3.89μs	15μs	8.25	2.36	0.393	53.32 KB
#5461	`WriteAndFlushEnrichedTraces`	net6.0	581μs	1.3μs	5.04μs	0.558	0	0	41.88 KB
#5461	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	1.68μs	6.5μs	0.326	0	0	41.77 KB
#5461	`WriteAndFlushEnrichedTraces`	net472	851μs	3.41μs	13.2μs	8.33	2.5	0.417	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.15μs	0.715ns	2.77ns	0.011	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.44μs	0.986ns	3.82ns	0.0109	808 B
master	`ExecuteNonQuery`	net472	1.75μs	1.32ns	5.1ns	0.122	770 B
#5461	`ExecuteNonQuery`	net6.0	1.14μs	1.02ns	3.96ns	0.0114	808 B
#5461	`ExecuteNonQuery`	netcoreapp3.1	1.45μs	1.19ns	4.63ns	0.0108	808 B
#5461	`ExecuteNonQuery`	net472	1.78μs	1.55ns	6.01ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.3μs	0.726ns	2.72ns	0.0138	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.818ns	3.06ns	0.0135	0	976 B
master	`CallElasticsearch`	net472	2.32μs	1.7ns	6.6ns	0.158	0.00116	995 B
master	`CallElasticsearchAsync`	net6.0	1.22μs	0.828ns	3.1ns	0.0135	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	6.68ns	25.9ns	0.0134	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	1.54ns	5.96ns	0.167	0.00128	1.05 KB
#5461	`CallElasticsearch`	net6.0	1.25μs	0.897ns	3.23ns	0.0137	0	976 B
#5461	`CallElasticsearch`	netcoreapp3.1	1.48μs	0.397ns	1.54ns	0.0138	0	976 B
#5461	`CallElasticsearch`	net472	2.49μs	0.702ns	2.53ns	0.158	0.00124	995 B
#5461	`CallElasticsearchAsync`	net6.0	1.25μs	0.9ns	3.37ns	0.0131	0	952 B
#5461	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.618ns	2.31ns	0.0134	0	1.02 KB
#5461	`CallElasticsearchAsync`	net472	2.4μs	2.05ns	7.94ns	0.167	0.0012	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.2μs	1.71ns	6.61ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	4.39ns	16.4ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.8μs	0.761ns	2.85ns	0.145	915 B
#5461	`ExecuteAsync`	net6.0	1.27μs	0.759ns	2.84ns	0.0134	952 B
#5461	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.688ns	2.67ns	0.0125	952 B
#5461	`ExecuteAsync`	net472	1.88μs	0.868ns	3.25ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.32μs	1.49ns	5.77ns	0.03	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.1μs	1.67ns	6.03ns	0.0359	2.76 KB
master	`SendAsync`	net472	7.66μs	2.25ns	8.72ns	0.493	3.12 KB
#5461	`SendAsync`	net6.0	4.06μs	2.77ns	10.4ns	0.0303	2.22 KB
#5461	`SendAsync`	netcoreapp3.1	5.04μs	1.98ns	7.68ns	0.0377	2.76 KB
#5461	`SendAsync`	net472	7.6μs	2.63ns	10.2ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.452ns	1.75ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.34μs	1.22ns	4.56ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.55μs	1.92ns	7.44ns	0.25	1.57 KB
#5461	`EnrichedLog`	net6.0	1.42μs	0.619ns	2.32ns	0.0228	1.64 KB
#5461	`EnrichedLog`	netcoreapp3.1	2.24μs	1.16ns	4.36ns	0.0215	1.64 KB
#5461	`EnrichedLog`	net472	2.68μs	1.24ns	4.45ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	70.3ns	272ns	0.0567	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	103ns	398ns	0.0587	0	4.28 KB
master	`EnrichedLog`	net472	148μs	93.6ns	363ns	0.668	0.223	4.46 KB
#5461	`EnrichedLog`	net6.0	115μs	231ns	894ns	0.0571	0	4.28 KB
#5461	`EnrichedLog`	netcoreapp3.1	118μs	265ns	1.03μs	0	0	4.28 KB
#5461	`EnrichedLog`	net472	149μs	127ns	493ns	0.675	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.01μs	0.808ns	2.91ns	0.0301	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.04μs	1.29ns	5.01ns	0.0303	2.2 KB
master	`EnrichedLog`	net472	4.82μs	1.34ns	5.21ns	0.321	2.02 KB
#5461	`EnrichedLog`	net6.0	3.12μs	0.909ns	3.52ns	0.0311	2.2 KB
#5461	`EnrichedLog`	netcoreapp3.1	4.21μs	1.22ns	4.38ns	0.0295	2.2 KB
#5461	`EnrichedLog`	net472	4.68μs	1.08ns	4.18ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	1.29ns	5ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.8μs	0.826ns	3.2ns	0.0151	1.14 KB
master	`SendReceive`	net472	2.12μs	0.831ns	3.22ns	0.183	1.16 KB
#5461	`SendReceive`	net6.0	1.34μs	0.91ns	3.4ns	0.016	1.14 KB
#5461	`SendReceive`	netcoreapp3.1	1.7μs	0.584ns	2.26ns	0.0151	1.14 KB
#5461	`SendReceive`	net472	2.21μs	1.34ns	5.21ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	0.673ns	2.52ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.87μs	3.9ns	15.1ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.21μs	2.33ns	9.01ns	0.324	2.04 KB
#5461	`EnrichedLog`	net6.0	2.65μs	0.575ns	2.23ns	0.0227	1.6 KB
#5461	`EnrichedLog`	netcoreapp3.1	4.02μs	1.63ns	6.12ns	0.022	1.65 KB
#5461	`EnrichedLog`	net472	4.44μs	1.9ns	6.84ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5461

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.139	770.40	676.41

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	450ns	0.186ns	0.722ns	0.00798	576 B
master	`StartFinishSpan`	netcoreapp3.1	560ns	0.614ns	2.3ns	0.00784	576 B
master	`StartFinishSpan`	net472	731ns	1.07ns	4.13ns	0.0918	578 B
master	`StartFinishScope`	net6.0	472ns	0.104ns	0.404ns	0.00969	696 B
master	`StartFinishScope`	netcoreapp3.1	770ns	0.493ns	1.91ns	0.00952	696 B
master	`StartFinishScope`	net472	844ns	0.317ns	1.23ns	0.104	658 B
#5461	`StartFinishSpan`	net6.0	417ns	0.717ns	2.78ns	0.00811	576 B
#5461	`StartFinishSpan`	netcoreapp3.1	605ns	0.347ns	1.3ns	0.00761	576 B
#5461	`StartFinishSpan`	net472	762ns	0.579ns	2.09ns	0.0915	578 B
#5461	`StartFinishScope`	net6.0	497ns	0.111ns	0.416ns	0.00989	696 B
#5461	`StartFinishScope`	netcoreapp3.1	676ns	0.252ns	0.907ns	0.00947	696 B
#5461	`StartFinishScope`	net472	917ns	0.279ns	1.04ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	587ns	0.111ns	0.431ns	0.0097	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	919ns	0.367ns	1.42ns	0.00967	696 B
master	`RunOnMethodBegin`	net472	1.12μs	0.577ns	2.24ns	0.104	658 B
#5461	`RunOnMethodBegin`	net6.0	585ns	0.109ns	0.424ns	0.00966	696 B
#5461	`RunOnMethodBegin`	netcoreapp3.1	867ns	0.334ns	1.29ns	0.00953	696 B
#5461	`RunOnMethodBegin`	net472	1.13μs	0.443ns	1.72ns	0.104	658 B

andrewlock · 2024-04-18T09:37:51Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5461) (10.857M)   : 0, 10857041
    master (11.401M)   : 0, 11400540
    benchmarks/2.9.0 (11.424M)   : 0, 11423607

    section Automatic
    This PR (5461) (7.355M)   : 0, 7354610
    master (7.697M)   : 0, 7697307
    benchmarks/2.9.0 (8.277M)   : 0, 8277021

    section Trace stats
    master (7.813M)   : 0, 7812615

    section Manual
    This PR (5461) (9.724M)   : 0, 9724172
    master (9.678M)   : 0, 9677794

    section Manual + Automatic
    This PR (5461) (7.006M)   : 0, 7005864
    master (7.194M)   : 0, 7194228

    section Version Conflict
    master (6.350M)   : 0, 6350226

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5461) (9.409M)   : 0, 9408962
    master (9.543M)   : 0, 9543098
    benchmarks/2.9.0 (9.485M)   : 0, 9484821

    section Automatic
    This PR (5461) (6.673M)   : 0, 6672626
    master (6.715M)   : 0, 6715345

    section Trace stats
    master (6.762M)   : 0, 6762444

    section Manual
    This PR (5461) (8.287M)   : 0, 8286569
    master (7.978M)   : 0, 7977599

    section Manual + Automatic
    This PR (5461) (6.271M)   : 0, 6270880
    master (6.274M)   : 0, 6273730

    section Version Conflict
    master (5.645M)   : 0, 5644881

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5461) (10.088M)   : 0, 10088092
    master (9.681M)   : 0, 9680717
    benchmarks/2.9.0 (10.268M)   : 0, 10268195

    section Automatic
    This PR (5461) (7.076M)   : 0, 7075546
    master (7.080M)   : 0, 7080259
    benchmarks/2.9.0 (7.411M)   : 0, 7411287

    section Trace stats
    master (7.371M)   : 0, 7371239

    section Manual
    This PR (5461) (8.900M)   : 0, 8900372
    master (8.639M)   : 0, 8639008

    section Manual + Automatic
    This PR (5461) (6.926M)   : 0, 6925558
    master (6.736M)   : 0, 6736357

    section Version Conflict
    master (6.079M)   : 0, 6079443

datadog-ddstaging · 2024-05-23T13:24:22Z

Datadog Report

Branch report: shurivich/legacy_endpoint
Commit report: ce59ff9
Test service: dd-trace-dotnet

✅ 0 Failed, 336189 Passed, 2042 Skipped, 21h 57m 18.92s Total Time

shurivich added the area:debugger label Apr 18, 2024

shurivich self-assigned this Apr 18, 2024

shurivich requested a review from a team as a code owner April 18, 2024 08:37

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Apr 18, 2024

dudikeleti approved these changes Apr 18, 2024

View reviewed changes

andrewlock approved these changes Apr 18, 2024

View reviewed changes

tracer/src/Datadog.Trace/Debugger/Upload/DiagnosticsUploadApi.cs Show resolved Hide resolved

tracer/src/Datadog.Trace/Debugger/Upload/DiagnosticsUploadApi.cs Outdated Show resolved Hide resolved

shurivich added 2 commits May 23, 2024 14:18

Check specific path for diagnostics upload

a5ce887

add test

ce59ff9

shurivich force-pushed the shurivich/legacy_endpoint branch from a5cac62 to ce59ff9 Compare May 23, 2024 13:08

shurivich requested a review from a team as a code owner May 23, 2024 13:08

shurivich merged commit d7ec765 into master May 27, 2024
62 checks passed

shurivich deleted the shurivich/legacy_endpoint branch May 27, 2024 08:59

github-actions bot added this to the vNext-v2 milestone May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Check specific path for diagnostics upload #5461

[Dynamic Instrumentation] Check specific path for diagnostics upload #5461

shurivich commented Apr 18, 2024

datadog-ddstaging bot commented Apr 18, 2024 •

edited

Loading

andrewlock commented Apr 18, 2024 •

edited

Loading

andrewlock commented Apr 18, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #5461

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5461

Raw results

Raw results

andrewlock commented Apr 18, 2024 •

edited

Loading

datadog-ddstaging bot commented May 23, 2024 •

edited

Loading

[Dynamic Instrumentation] Check specific path for diagnostics upload #5461

[Dynamic Instrumentation] Check specific path for diagnostics upload #5461

Conversation

shurivich commented Apr 18, 2024

Summary of changes

Reason for change

datadog-ddstaging bot commented Apr 18, 2024 • edited Loading

Datadog Report

andrewlock commented Apr 18, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 18, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5461

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5461

Raw results

Raw results

andrewlock commented Apr 18, 2024 • edited Loading

Throughput/Crank Report:zap:

datadog-ddstaging bot commented May 23, 2024 • edited Loading

Datadog Report

datadog-ddstaging bot commented Apr 18, 2024 •

edited

Loading

andrewlock commented Apr 18, 2024 •

edited

Loading

andrewlock commented Apr 18, 2024 •

edited

Loading

andrewlock commented Apr 18, 2024 •

edited

Loading

datadog-ddstaging bot commented May 23, 2024 •

edited

Loading