[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

gleocadie · 2024-05-22T14:28:55Z

Summary of changes

Bump FluentAssertions package.

Reason for change

To be able to use new string matchers.

Implementation details

Update nuget package

Test coverage

Other details

chrisnas

LGTM

datadog-ddstaging · 2024-05-22T14:44:31Z

Datadog Report

Branch report: gleocadie/bump-fluent-assertions-version
Commit report: 07a874f
Test service: dd-trace-dotnet

✅ 0 Failed, 340736 Passed, 1874 Skipped, 14h 44m 58.24s Total Time

andrewlock · 2024-05-22T14:54:34Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5599) - mean (72ms)  : 64, 80
     .   : milestone, 72,
    master - mean (74ms)  : 65, 83
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5599) - mean (1,005ms)  : 977, 1032
     .   : milestone, 1005,
    master - mean (998ms)  : 966, 1030
     .   : milestone, 998,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5599) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5599) - mean (718ms)  : 682, 755
     .   : milestone, 718,
    master - mean (718ms)  : 685, 752
     .   : milestone, 718,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5599) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5599) - mean (670ms)  : 640, 699
     .   : milestone, 670,
    master - mean (676ms)  : 645, 708
     .   : milestone, 676,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5599) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (5599) - mean (1,122ms)  : 1099, 1145
     .   : milestone, 1122,
    master - mean (1,111ms)  : 1090, 1132
     .   : milestone, 1111,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5599) - mean (278ms)  : 272, 283
     .   : milestone, 278,
    master - mean (277ms)  : 271, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5599) - mean (908ms)  : 875, 942
     .   : milestone, 908,
    master - mean (909ms)  : 879, 939
     .   : milestone, 909,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5599) - mean (268ms)  : 262, 273
     .   : milestone, 268,
    master - mean (269ms)  : 263, 275
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (5599) - mean (891ms)  : 867, 914
     .   : milestone, 891,
    master - mean (888ms)  : 865, 912
     .   : milestone, 888,

andrewlock

Can we have this for tracer too?! :D

andrewlock · 2024-05-22T15:34:49Z

Benchmarks Report for tracer 🐌

Benchmarks for #5599 compared to master:

2 benchmarks are faster, with geometric mean 1.133
2 benchmarks are slower, with geometric mean 1.135
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.92μs	48.1ns	272ns	0.0264	0.0132	0	7.56 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	57.2ns	308ns	0.0272	0.0109	0	7.66 KB
master	`StartStopWithChild`	net472	17.7μs	84.6ns	349ns	1.34	0.344	0.103	8.07 KB
#5599	`StartStopWithChild`	net6.0	8.56μs	43ns	197ns	0.0175	0.00876	0	7.55 KB
#5599	`StartStopWithChild`	netcoreapp3.1	10.7μs	57.7ns	316ns	0.0328	0.0164	0	7.65 KB
#5599	`StartStopWithChild`	net472	17.2μs	62ns	240ns	1.34	0.362	0.109	8.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	489μs	124ns	447ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	378ns	1.41μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	836μs	168ns	630ns	0.417	3.3 KB
#5599	`WriteAndFlushEnrichedTraces`	net6.0	471μs	226ns	875ns	0	2.7 KB
#5599	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	318ns	1.19μs	0	2.7 KB
#5599	`WriteAndFlushEnrichedTraces`	net472	831μs	266ns	995ns	0.414	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	300ns	1.16μs	0.255	18.44 KB
master	`SendRequest`	netcoreapp3.1	193μs	385ns	1.49μs	0.193	20.61 KB
master	`SendRequest`	net472	0.00115ns	0.000449ns	0.00174ns	0	0 b
#5599	`SendRequest`	net6.0	173μs	281ns	1.09μs	0.258	18.44 KB
#5599	`SendRequest`	netcoreapp3.1	191μs	382ns	1.48μs	0.191	20.61 KB
#5599	`SendRequest`	net472	0.15ns	0.00104ns	0.00403ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5599

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.61 KB	41.92 KB	317 B	0.76%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	556μs	839ns	3.25μs	0.563	0	0	41.61 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	1.44μs	5.6μs	0.329	0	0	41.94 KB
master	`WriteAndFlushEnrichedTraces`	net472	850μs	3.92μs	15.7μs	8.45	2.53	0.422	53.27 KB
#5599	`WriteAndFlushEnrichedTraces`	net6.0	580μs	2.87μs	12.8μs	0.556	0	0	41.92 KB
#5599	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	669μs	1.16μs	4.36μs	0.334	0	0	41.96 KB
#5599	`WriteAndFlushEnrichedTraces`	net472	840μs	3.74μs	14.5μs	8.28	2.48	0.414	53.26 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.09μs	0.617ns	2.39ns	0.0114	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.49μs	1.27ns	4.91ns	0.0104	808 B
master	`ExecuteNonQuery`	net472	1.7μs	1.33ns	5.14ns	0.122	770 B
#5599	`ExecuteNonQuery`	net6.0	1.1μs	0.645ns	2.5ns	0.011	808 B
#5599	`ExecuteNonQuery`	netcoreapp3.1	1.45μs	1.75ns	6.76ns	0.0109	808 B
#5599	`ExecuteNonQuery`	net472	1.66μs	1.39ns	5.38ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5599

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.140	1,109.80	1,265.63

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.11μs	0.691ns	2.39ns	0.0135	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	1.04ns	3.74ns	0.0133	0	976 B
master	`CallElasticsearch`	net472	2.52μs	2.04ns	7.9ns	0.158	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.36μs	0.663ns	2.48ns	0.0135	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	1.78ns	6.91ns	0.0138	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.63μs	1.82ns	7.05ns	0.167	0	1.05 KB
#5599	`CallElasticsearch`	net6.0	1.27μs	1.19ns	4.59ns	0.0133	0	976 B
#5599	`CallElasticsearch`	netcoreapp3.1	1.53μs	1.91ns	7.4ns	0.0129	0	976 B
#5599	`CallElasticsearch`	net472	2.45μs	1.46ns	5.65ns	0.158	0.00122	995 B
#5599	`CallElasticsearchAsync`	net6.0	1.31μs	1.15ns	4.47ns	0.0131	0	952 B
#5599	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	1.51ns	5.85ns	0.0135	0	1.02 KB
#5599	`CallElasticsearchAsync`	net472	2.59μs	1.05ns	4.07ns	0.166	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5599

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.130	1,200.22	1,356.14

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.2μs	3.93ns	15.2ns	0.0131	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.678ns	2.44ns	0.0123	0	952 B
master	`ExecuteAsync`	net472	1.81μs	0.763ns	2.95ns	0.145	0.000903	915 B
#5599	`ExecuteAsync`	net6.0	1.36μs	0.617ns	2.31ns	0.0136	0	952 B
#5599	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.65ns	6.37ns	0.013	0	952 B
#5599	`ExecuteAsync`	net472	1.84μs	0.476ns	1.71ns	0.145	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.18μs	2.06ns	7.99ns	0.0313	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.2μs	0.956ns	3.31ns	0.0364	2.76 KB
master	`SendAsync`	net472	7.54μs	2.36ns	9.15ns	0.492	3.12 KB
#5599	`SendAsync`	net6.0	4.1μs	3.35ns	13ns	0.0308	2.22 KB
#5599	`SendAsync`	netcoreapp3.1	5.07μs	2.08ns	7.77ns	0.038	2.76 KB
#5599	`SendAsync`	net472	7.53μs	2.25ns	8.73ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.43μs	1.44ns	5.56ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.3μs	1.08ns	4.04ns	0.0229	1.64 KB
master	`EnrichedLog`	net472	2.69μs	1.68ns	6.52ns	0.25	1.57 KB
#5599	`EnrichedLog`	net6.0	1.47μs	1.25ns	4.68ns	0.0234	1.64 KB
#5599	`EnrichedLog`	netcoreapp3.1	2.25μs	0.71ns	2.66ns	0.0225	1.64 KB
#5599	`EnrichedLog`	net472	2.54μs	0.839ns	3.14ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	138ns	518ns	0.0575	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	102ns	396ns	0	0	4.28 KB
master	`EnrichedLog`	net472	148μs	85.4ns	331ns	0.668	0.223	4.46 KB
#5599	`EnrichedLog`	net6.0	113μs	78.5ns	304ns	0.0566	0	4.28 KB
#5599	`EnrichedLog`	netcoreapp3.1	117μs	125ns	483ns	0.0585	0	4.28 KB
#5599	`EnrichedLog`	net472	149μs	109ns	391ns	0.672	0.224	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.9μs	1.11ns	4.31ns	0.0319	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.09μs	0.99ns	3.7ns	0.0287	2.2 KB
master	`EnrichedLog`	net472	4.77μs	4.25ns	16.4ns	0.319	2.02 KB
#5599	`EnrichedLog`	net6.0	3.04μs	0.639ns	2.39ns	0.0304	2.2 KB
#5599	`EnrichedLog`	netcoreapp3.1	4.1μs	1.62ns	5.84ns	0.0288	2.2 KB
#5599	`EnrichedLog`	net472	4.89μs	1.06ns	3.98ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.36μs	0.335ns	1.3ns	0.0156	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.82μs	2.34ns	9.07ns	0.0155	1.14 KB
master	`SendReceive`	net472	2.16μs	0.95ns	3.43ns	0.183	1.16 KB
#5599	`SendReceive`	net6.0	1.3μs	0.728ns	2.82ns	0.0162	1.14 KB
#5599	`SendReceive`	netcoreapp3.1	1.81μs	0.777ns	2.8ns	0.0152	1.14 KB
#5599	`SendReceive`	net472	2.13μs	0.562ns	2.1ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.81μs	0.94ns	3.64ns	0.0225	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.85μs	1.12ns	4.35ns	0.0209	1.65 KB
master	`EnrichedLog`	net472	4.35μs	4.64ns	17.4ns	0.323	2.04 KB
#5599	`EnrichedLog`	net6.0	2.76μs	3.44ns	13.3ns	0.022	1.6 KB
#5599	`EnrichedLog`	netcoreapp3.1	3.89μs	1.68ns	6.52ns	0.0214	1.65 KB
#5599	`EnrichedLog`	net472	4.39μs	2.44ns	8.79ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5599

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.145	447.79	391.13

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	448ns	0.15ns	0.581ns	0.00806	576 B
master	`StartFinishSpan`	netcoreapp3.1	556ns	0.253ns	0.945ns	0.00776	576 B
master	`StartFinishSpan`	net472	637ns	0.644ns	2.49ns	0.0916	578 B
master	`StartFinishScope`	net6.0	483ns	0.199ns	0.769ns	0.00969	696 B
master	`StartFinishScope`	netcoreapp3.1	820ns	0.427ns	1.65ns	0.00941	696 B
master	`StartFinishScope`	net472	898ns	0.667ns	2.58ns	0.104	658 B
#5599	`StartFinishSpan`	net6.0	391ns	0.0828ns	0.321ns	0.00799	576 B
#5599	`StartFinishSpan`	netcoreapp3.1	596ns	0.426ns	1.65ns	0.00776	576 B
#5599	`StartFinishSpan`	net472	687ns	0.407ns	1.58ns	0.0917	578 B
#5599	`StartFinishScope`	net6.0	475ns	0.111ns	0.43ns	0.00979	696 B
#5599	`StartFinishScope`	netcoreapp3.1	764ns	0.355ns	1.38ns	0.00945	696 B
#5599	`StartFinishScope`	net472	830ns	1.54ns	5.95ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5599

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	1.120	1,164.87	1,039.61

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	689ns	0.298ns	1.16ns	0.00998	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	894ns	1.61ns	6.25ns	0.00931	696 B
master	`RunOnMethodBegin`	net472	1.16μs	0.444ns	1.72ns	0.104	658 B
#5599	`RunOnMethodBegin`	net6.0	653ns	0.387ns	1.39ns	0.00973	696 B
#5599	`RunOnMethodBegin`	netcoreapp3.1	854ns	0.416ns	1.56ns	0.00945	696 B
#5599	`RunOnMethodBegin`	net472	1.04μs	0.975ns	3.77ns	0.104	658 B

gleocadie · 2024-05-22T16:00:58Z

Can we have this for tracer too?! :D

sure I can do it :)

andrewlock · 2024-05-22T22:29:38Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5599) (11.637M)   : 0, 11636811
    master (11.828M)   : 0, 11828231
    benchmarks/2.9.0 (11.526M)   : 0, 11525850

    section Automatic
    This PR (5599) (5.553M)   : crit ,0, 5552955
    master (8.062M)   : 0, 8062178
    benchmarks/2.9.0 (8.220M)   : 0, 8219739

    section Trace stats
    master (8.286M)   : 0, 8285547

    section Manual
    This PR (5599) (9.994M)   : 0, 9993929
    master (10.297M)   : 0, 10296840

    section Manual + Automatic
    This PR (5599) (7.233M)   : 0, 7233349
    master (7.608M)   : 0, 7607808

    section Version Conflict
    master (6.850M)   : 0, 6849792

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5599) (9.752M)   : 0, 9752069
    master (9.521M)   : 0, 9521491
    benchmarks/2.9.0 (9.714M)   : 0, 9713973

    section Automatic
    This PR (5599) (6.667M)   : 0, 6666663
    master (6.732M)   : 0, 6732478

    section Trace stats
    master (6.905M)   : 0, 6905380

    section Manual
    This PR (5599) (8.233M)   : 0, 8233165
    master (8.424M)   : 0, 8423753

    section Manual + Automatic
    This PR (5599) (6.224M)   : 0, 6224418
    master (6.158M)   : 0, 6157722

    section Version Conflict
    master (5.707M)   : 0, 5706553

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5599) (10.027M)   : 0, 10027272
    master (9.694M)   : 0, 9694419
    benchmarks/2.9.0 (9.834M)   : 0, 9834486

    section Automatic
    This PR (5599) (7.090M)   : 0, 7089568
    master (7.027M)   : 0, 7027138
    benchmarks/2.9.0 (7.269M)   : 0, 7268988

    section Trace stats
    master (7.263M)   : 0, 7262766

    section Manual
    This PR (5599) (8.964M)   : 0, 8964005
    master (8.519M)   : 0, 8518988

    section Manual + Automatic
    This PR (5599) (6.840M)   : 0, 6839806
    master (6.750M)   : 0, 6750268

    section Version Conflict
    master (6.028M)   : 0, 6027558

Bump FluentAssertions to 6.12.0

083fca3

gleocadie requested a review from a team as a code owner May 22, 2024 14:28

github-actions bot added the area:profiler Issues related to the continous-profiler label May 22, 2024

chrisnas approved these changes May 22, 2024

View reviewed changes

andrewlock approved these changes May 22, 2024

View reviewed changes

Fix tests

c6823f9

Bump for tracer too

4ee9e1b

gleocadie requested review from a team as code owners May 22, 2024 16:05

gleocadie changed the title ~~[Profiler] Bump FluentAssertions to 6.12.0~~ [Profiler/Tracer] Bump FluentAssertions to 6.12.0 May 22, 2024

gleocadie added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label May 22, 2024

Fix tests

07a874f

gleocadie merged commit 5946a8d into master May 23, 2024
65 checks passed

gleocadie deleted the gleocadie/bump-fluent-assertions-version branch May 23, 2024 13:13

github-actions bot added this to the vNext-v2 milestone May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

gleocadie commented May 22, 2024

chrisnas left a comment

datadog-ddstaging bot commented May 22, 2024 •

edited

Loading

andrewlock commented May 22, 2024 •

edited

Loading

andrewlock left a comment

andrewlock commented May 22, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #5599

Raw results

Raw results

Slower ⚠️ in #5599

Raw results

Slower ⚠️ in #5599

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5599

Raw results

Faster 🎉 in #5599

Raw results

gleocadie commented May 22, 2024

andrewlock commented May 22, 2024

[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

Conversation

gleocadie commented May 22, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

chrisnas left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented May 22, 2024 • edited Loading

Datadog Report

andrewlock commented May 22, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock commented May 22, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5599

Raw results

Raw results

Slower ⚠️ in #5599

Raw results

Slower ⚠️ in #5599

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5599

Raw results

Faster 🎉 in #5599

Raw results

gleocadie commented May 22, 2024

andrewlock commented May 22, 2024

Throughput/Crank Report:zap:

datadog-ddstaging bot commented May 22, 2024 •

edited

Loading

andrewlock commented May 22, 2024 •

edited

Loading

andrewlock commented May 22, 2024 •

edited

Loading