Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

Merged
merged 4 commits into from
May 23, 2024
Merged

[Profiler/Tracer] Bump FluentAssertions to 6.12.0 #5599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
083fca3
Bump FluentAssertions to 6.12.0
gleocadie May 22, 2024
c6823f9
Fix tests
gleocadie May 22, 2024
4ee9e1b
Bump for tracer too
gleocadie May 22, 2024
07a874f
Fix tests
gleocadie May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion profiler/test/Datadog.Profiler.IntegrationTests/Datadog.Profiler.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="FluentAssertions" Version="5.10.3" />
<PackageReference Include="FluentAssertions" Version="6.12.0" />
<PackageReference Include="Google.Protobuf" Version="3.20.1" />
<PackageReference Include="K4os.Compression.LZ4.Streams" Version="1.3.6" />
<PackageReference Include="MessagePack" Version="1.9.11" />
Expand Down
4 changes: 2 additions & 2 deletions profiler/test/Datadog.Profiler.IntegrationTests/Exceptions/ExceptionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ public void Sampling(string appName, string framework, string appAssembly)
// The profiler samples the exception but also upscale the values after.
// So we just check that we are in the right order of magnitude.
// Note: with timestamps, upscaling will round down due to the lack of aggregation
exceptionCounts.Should().ContainKey("System.Exception").WhichValue.Should().BeCloseTo(4000, 300);
exceptionCounts.Should().ContainKey("System.Exception").WhoseValue.Should().BeCloseTo(4000, 300);

// System.InvalidOperationException is seen only once, so it should be sampled
// despite the sampler being saturated by the 4000 System.Exception
exceptionCounts.Should().ContainKey("System.InvalidOperationException").WhichValue.Should().Be(1);
exceptionCounts.Should().ContainKey("System.InvalidOperationException").WhoseValue.Should().Be(1);
}

[TestAppFact("Samples.ExceptionGenerator")]
Expand Down
Loading