Fix gitlab build (#6025 -> v2) #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary of changes Enables longpath support on the gitlab Windows jobs ## Reason for change We moved the location of the repo in GitLab, which increased the path length, and we hit long path issues ## Implementation details Make the runner set `git config --system core.longpaths true` - it's [a crazy olde time restriction](https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=powershell), so realistically everyone should have this anyway ## Test coverage The build works, so it's fixed! ## Other details We could shorten the paths to work around it, but it's just another accident waiting to happen. This is not the first time 🙈 <!--⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
andrewlock
added
the
area:builds
robertpi
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Enables longpath support on the gitlab Windows jobs
Reason for change
We moved the location of the repo in GitLab, which increased the path length, and we hit long path issues
Implementation details
Make the runner set
git config --system core.longpaths true- it's a crazy olde time restriction, so realistically everyone should have this anywayTest coverage
The build works, so it's fixed!
Other details
We could shorten the paths to work around it, but it's just another accident waiting to happen. This is not the first time 🙈
Backport of #6025