Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitlab build (#6025 -> v2) #6027

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Commits on Sep 12, 2024

  1. Fix gitlab build (#6025)

    ## Summary of changes
    
    Enables longpath support on the gitlab Windows jobs
    
    ## Reason for change
    
    We moved the location of the repo in GitLab, which increased the path
    length, and we hit long path issues
    
    ## Implementation details
    
    Make the runner set `git config --system core.longpaths true` - it's [a
    crazy olde time
    restriction](https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=powershell),
    so realistically everyone should have this anyway
    
    ## Test coverage
    
    The build works, so it's fixed!
    
    ## Other details
    We could shorten the paths to work around it, but it's just another
    accident waiting to happen. This is not the first time 🙈
    
    <!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
    merging. Unless CODEOWNERS specifies otherwise, for external teams it is
    typically best to have one review from a team member, and one review
    from apm-dotnet. Trivial changes do not require 2 reviews. -->
    andrewlock committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c4778d6 View commit details
    Browse the repository at this point in the history