Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify release process #616

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

colin-higgins
Copy link
Member

Changes proposed in this pull request:
Simplify the release process into a single executable where possible

@DataDog/apm-dotnet

@colin-higgins colin-higgins added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 28, 2020
@colin-higgins colin-higgins requested a review from a team as a code owner January 28, 2020 14:52
@colin-higgins colin-higgins self-assigned this Jan 28, 2020
{
private const string RequiredBuildConfig = "Release";

public static string[] GetTracerReleaseBinContent(string frameworkMoniker, string extension = "dll")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could probably even do some more code-sharing between these two methods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure

Copy link
Collaborator

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit, but otherwise looks great!

@colin-higgins colin-higgins merged commit 1247895 into master Jan 28, 2020
@colin-higgins colin-higgins deleted the colin/tools/refactor-release-process branch January 28, 2020 16:34
@lucaspimentel lucaspimentel added this to the 1.12.0 milestone Feb 5, 2020
MikeGoldsmith pushed a commit to lightstep/ls-trace-dotnet that referenced this pull request Mar 20, 2020
* Simplify release process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants