-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify release process #616
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
using System; | ||
using System.IO; | ||
using Datadog.Core.Tools; | ||
|
||
namespace PrepareRelease.Tools | ||
{ | ||
public static class DependencyHelpers | ||
{ | ||
private const string RequiredBuildConfig = "Release"; | ||
|
||
public static string[] GetTracerReleaseBinContent(string frameworkMoniker, string extension = "dll") | ||
{ | ||
var solutionDirectory = EnvironmentTools.GetSolutionDirectory(); | ||
var projectBin = | ||
Path.Combine( | ||
solutionDirectory, | ||
"src", | ||
"Datadog.Trace.ClrProfiler.Managed", | ||
"bin", | ||
RequiredBuildConfig); | ||
|
||
var outputFolder = Path.Combine(projectBin, frameworkMoniker); | ||
|
||
var filePaths = Directory.GetFiles( | ||
outputFolder, | ||
$"*.{extension}", | ||
SearchOption.AllDirectories); | ||
|
||
if (filePaths.Length == 0) | ||
{ | ||
throw new Exception("Be sure to build in release mode before running this tool."); | ||
} | ||
|
||
return filePaths; | ||
} | ||
|
||
public static string[] GetProfilerReleaseBinContent(string architecture, string extension = "dll") | ||
{ | ||
var solutionDirectory = EnvironmentTools.GetSolutionDirectory(); | ||
var outputFolder = | ||
Path.Combine( | ||
solutionDirectory, | ||
"src", | ||
"Datadog.Trace.ClrProfiler.Native", | ||
"bin", | ||
RequiredBuildConfig, | ||
architecture); | ||
|
||
var filePaths = Directory.GetFiles( | ||
outputFolder, | ||
$"*.{extension}", | ||
SearchOption.AllDirectories); | ||
|
||
if (filePaths.Length == 0) | ||
{ | ||
throw new Exception("Be sure to build in release mode before running this tool."); | ||
} | ||
|
||
return filePaths; | ||
} | ||
} | ||
} |
16 changes: 0 additions & 16 deletions
16
tools/GenerateIntegrationDefinitions/GenerateIntegrationDefinitions.csproj
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
tools/GenerateIntegrationDefinitions/Properties/launchSettings.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
using System; | ||
using System.Linq; | ||
|
||
namespace PrepareRelease | ||
{ | ||
public class Program | ||
{ | ||
public const string Versions = "versions"; | ||
public const string Integrations = "integrations"; | ||
public const string Msi = "msi"; | ||
|
||
public static void Main(string[] args) | ||
{ | ||
if (JobShouldRun(Integrations, args)) | ||
{ | ||
Console.WriteLine("--------------- Integrations Job Started ---------------"); | ||
GenerateIntegrationDefinitions.Run(); | ||
Console.WriteLine("--------------- Integrations Job Complete ---------------"); | ||
} | ||
|
||
if (JobShouldRun(Versions, args)) | ||
{ | ||
Console.WriteLine("--------------- Versions Job Started ---------------"); | ||
SetAllVersions.Run(); | ||
Console.WriteLine("--------------- Versions Job Complete ---------------"); | ||
} | ||
|
||
if (JobShouldRun(Msi, args)) | ||
{ | ||
Console.WriteLine("--------------- MSI Job Started ---------------"); | ||
SyncMsiContent.Run(); | ||
Console.WriteLine("--------------- MSI Job Complete ---------------"); | ||
} | ||
} | ||
|
||
private static bool JobShouldRun(string jobName, string[] args) | ||
{ | ||
return args.Length == 0 || args.Any(a => string.Equals(a, jobName, StringComparison.OrdinalIgnoreCase)); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You could probably even do some more code-sharing between these two methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure