Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary fields from endpoint events #4391

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Dec 6, 2022

What Does This Do

We don't use these fields, and removing them would have saved 26MiB in a customer profile close to our cutoff size.

Motivation

Additional Notes

@richardstartin richardstartin added the comp: profiling Profiling label Dec 6, 2022
@richardstartin richardstartin requested a review from a team as a code owner December 6, 2022 16:53
Copy link
Contributor

@mar-kolya mar-kolya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And off we go!

@richardstartin richardstartin force-pushed the rgs/trim-down-endpoint-events branch from 39e6082 to d8dd7ea Compare December 6, 2022 17:54
@richardstartin richardstartin merged commit 8a20a35 into master Dec 6, 2022
@richardstartin richardstartin deleted the rgs/trim-down-endpoint-events branch December 6, 2022 18:33
@github-actions github-actions bot added this to the 1.3.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants