Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary fields from endpoint events #4391

Merged
merged 1 commit into from
Dec 6, 2022
Merged

remove unnecessary fields from endpoint events #4391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions dd-trace-core/jfr-openjdk/src/main/java/datadog/trace/core/jfr/openjdk/EndpointEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,32 +19,11 @@ public class EndpointEvent extends Event implements EndpointTracker {
@Label("Endpoint")
private String endpoint = "unknown";

@Label("Trace Id")
private final long traceId;

@Label("Local Root Span Id")
private final long localRootSpanId;

/**
* Set to {@literal true} if the corresponding trace and checkpoints was kept by agent side
* sampler(s)
*/
@Label("Trace Sampled")
private boolean traceSampled = false;

@Label("Trace Sampling Priority (start)")
private final int samplingPriorityStart;

@Label("Trace Sampling Priority (end)")
private int samplingPriorityEnd;

@Label("Checkpoints Sampled")
private boolean checkpointsSampled = false;

public EndpointEvent(final DDSpan span) {
this.traceId = span.getTraceId().toLong();
this.localRootSpanId = span.getSpanId();
this.samplingPriorityStart = span.samplingPriority();
begin();
}

Expand All @@ -53,9 +32,6 @@ public void endpointWritten(DDSpan span, boolean traceSampled, boolean checkpoin
if (shouldCommit()) {
end();
this.endpoint = span.getResourceName().toString();
this.samplingPriorityEnd = span.samplingPriority();
this.traceSampled = traceSampled;
this.checkpointsSampled = checkpointsSampled;
commit();
}
}
Expand Down