Update ioredis type information documentation #2787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe rather than documenting a requirement to be lowercased we should just change it to allow it to be case insensitive? |
|
In this case, is this a change you want only for this plugin, all the redis plugins, all plugins? |
tlhunter
force-pushed
the
ioredis/blocklist
branch
from
ab85e8a to
8d8721f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2787 +/- ##
==========================================
- Coverage 84.60% 84.45% -0.16%
==========================================
Files 234 232 -2
Lines 9817 9642 -175
Branches 33 33
==========================================
- Hits 8306 8143 -163
+ Misses 1511 1499 -12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the type documentation to inform developers to use lowercase
iorediscommandsMotivation
The ioredis plugin is based on the redis plugin which formats the command to uppercase when starting the span. This can be confusing when trying to blocklist a command which is represented in uppercase in the Datadog APM UI
Plugin Checklist
Additional Notes