-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ts errors #3912
Merged
Merged
Fix ts errors #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3912 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 237 237
Lines 10147 10147
Branches 33 33
=======================================
Hits 8595 8595
Misses 1552 1552 ☔ View full report in Codecov by Sentry. |
nsavoire
reviewed
Jan 2, 2024
If options are not specified (and therefore if `options.orphanable !== false`) then `span` and the `done` callback are guaranteed to be set
simon-id
reviewed
Jan 2, 2024
Closed
tlhunter
previously approved these changes
Jan 2, 2024
Closed
simon-id
previously approved these changes
Jan 3, 2024
simon-id
approved these changes
Jan 3, 2024
szegedi
approved these changes
Jan 3, 2024
Qard
added
dont-land-on-v3.x
If a commit depends on a major change not included in v3.x
dont-land-on-v4.x
If a commit depends on a major change not included in v4.x
labels
Jan 3, 2024
This was referenced Jan 10, 2024
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dont-land-on-v3.x
If a commit depends on a major change not included in v3.x
dont-land-on-v4.x
If a commit depends on a major change not included in v4.x
semver-major
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2693
Fixes #2787
What does this PR do?
Takes #2693 and fixes remaining TypeScript errors. I've also included the minor docs change in #2787.
Motivation
There's lots of TypeScript users. We should better support them.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.