v5.0.0-proposal #3920

khanayan123 · 2024-01-02T22:12:58Z

Breaking Changes

More information about the breaking changes from this release can be found in
the migration guide.

core: drop support for Node 16 (drop support for node 16 in preparation for v5 release #3905)
core: fix TypeScript errors (Fix ts errors #3912)

Features

profiling: Add experimental CPU profiler ([profiling] Add experimental CPU profiler #3895)

Improvements

profiling: GA Code hotspots and endpoint collection (PROF-8714: GA Code hotspots and endpoint collection by defaulting them to true #3940)

github-actions · 2024-01-02T22:13:43Z

Overall package size

Self size: 5.82 MB
Deduped: 61.48 MB
No deduping: 62.23 MB

Dependency sizes

name	version	self size	total size
@datadog/native-iast-taint-tracking	1.6.4	16.43 MB	16.44 MB
@datadog/native-appsec	6.0.0	14.48 MB	14.48 MB
@datadog/pprof	5.0.0	9.59 MB	10.44 MB
protobufjs	7.2.5	2.77 MB	6.56 MB
@datadog/native-iast-rewriter	2.2.2	2.29 MB	2.37 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.4.1	780.32 kB	780.32 kB
import-in-the-middle	1.7.2	45.99 kB	709.38 kB
pprof-format	2.0.7	588.12 kB	588.12 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.4	93.4 kB	123.8 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ipaddr.js	2.1.0	60.23 kB	60.23 kB
ignore	5.2.4	51.22 kB	51.22 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
tlhunter-sorted-set	0.1.0	24.94 kB	24.94 kB
limiter	1.1.5	23.17 kB	23.17 kB
dc-polyfill	0.1.2	22.77 kB	22.77 kB
retry	0.13.1	18.85 kB	18.85 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
node-abort-controller	3.1.1	16.89 kB	16.89 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
jest-docblock	29.7.0	8.99 kB	12.76 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2024-01-02T22:14:47Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7bb99d1) 84.70% compared to head (183ed9d) 85.01%.

Files	Patch %	Lines
...ackages/dd-trace/src/profiling/profilers/events.js	0.00%	5 Missing ⚠️
packages/dd-trace/src/sampling_rule.js	96.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             v5.x    #3920      +/-   ##
==========================================
+ Coverage   84.70%   85.01%   +0.30%     
==========================================
  Files         237      238       +1     
  Lines       10147    10176      +29     
  Branches       33       33              
==========================================
+ Hits         8595     8651      +56     
+ Misses       1552     1525      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pr-commenter · 2024-01-02T22:19:25Z

Benchmarks

Benchmark execution time: 2024-01-09 18:18:33

Comparing candidate commit 183ed9d in PR branch v5.0.0-proposal with baseline commit 7bb99d1 in branch v5.x.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

🟩 max_rss_usage [-124.604MB; -113.836MB] or [-13.152%; -12.015%]

* Update typing for `tracer.trace` If options are not specified (and therefore if `options.orphanable !== false`) then `span` and the `done` callback are guaranteed to be set * Fix other TypeScript errors * Make trace done callback return value void --------- Co-authored-by: Janek Lasocki-Biczysko <janek.lb@gmail.com>

* drop support for node 16 in preparation for v5 release

* Ignore samples without endpoints instead of asserting all will have endpoints * Emit base64-encoded pprof in an error message so we can debug flaky tests

…r.close() (#3926) https://issues.couchbase.com/browse/JSCBC-936

* Add CPU profiler * Avoid restarting profiling for last collect Upon process exit, profiler collects profiles a last time and was restarting all profilers before stopping them. Avoid this useless restart by changing the profiler API and make `profile()` methode take a restart argument. * Bump pprof-nodejs version

* set limiter version to 1.1.5 * reorder packages list * update import-in-the-middle lockfile entry

tlhunter · 2024-01-09T17:30:52Z

packages/dd-trace/src/sampling_rule.js

@@ -0,0 +1,130 @@
+'use strict'


Just to confirm, is this feature not landing in the v4.x branch? @Qard @khanayan123

It's a minor. It should have already have landed, as far as I know. 🤔

this feature already landed on v4.x and v3.x. This PR rebased on top of master but v5.x is behind master which is why this commit is showing up

simon-id · 2024-01-10T04:55:16Z

aren't we missing updates in the README ? like saying that v5 is latest instead of v4 and updating the release schedule table ?

khanayan123 · 2024-01-10T14:37:39Z

aren't we missing updates in the README ? like saying that v5 is latest instead of v4 and updating the release schedule table ?

Those updates are in this PR: #3918

which will be merged in after this PR

robertomonteromiguel and others added 11 commits January 3, 2024 10:11

Parametric tests: Remove obsolete CI code (#3922)

e8df0fa

speed up test by stubbing (#3923)

e2df7ec

Implement extended sampling (#3904)

c0e0b2b

drop support for node 16 in preparation for v5 release (#3905)

f4d3218

* drop support for node 16 in preparation for v5 release

PROF-8850: Add diagnostic to flaky test (#3927)

9e5b158

* Ignore samples without endpoints instead of asserting all will have endpoints * Emit base64-encoded pprof in an error message so we can debug flaky tests

Fix couchbase segfault. On >=3.2.0 <3.2.2 it would segfault on cluste…

0f3b143

…r.close() (#3926) https://issues.couchbase.com/browse/JSCBC-936

bump up iitm version (#3929)

cfc2436

Code hotspots and endpoint collection now enabled by default (#3940)

aa7ca3b

Pin limiter version to 1.1.5 (#3938)

d50c9d9

* set limiter version to 1.1.5 * reorder packages list * update import-in-the-middle lockfile entry

khanayan123 force-pushed the v5.0.0-proposal branch from 72a6d9d to b4cc214 Compare January 9, 2024 15:43

khanayan123 changed the title ~~v5.0.0~~ v5.0.0-proposal Jan 9, 2024

khanayan123 added the semver-patch label Jan 9, 2024

khanayan123 marked this pull request as ready for review January 9, 2024 17:19

khanayan123 requested review from a team as code owners January 9, 2024 17:19

khanayan123 requested a review from a team January 9, 2024 17:19

khanayan123 requested review from a team as code owners January 9, 2024 17:19

khanayan123 requested a review from jbertran January 9, 2024 17:19

tlhunter reviewed Jan 9, 2024

View reviewed changes

khanayan123 added 2 commits January 9, 2024 13:11

update CODEOWNERS for v5.x branch

1cdb05a

v5.0.0

183ed9d

khanayan123 force-pushed the v5.0.0-proposal branch from b4cc214 to 183ed9d Compare January 9, 2024 18:11

khanayan123 requested a review from tlhunter January 9, 2024 18:12

khanayan123 requested a review from Qard January 9, 2024 18:12

khanayan123 closed this Jan 10, 2024

khanayan123 deleted the v5.0.0-proposal branch January 10, 2024 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5.0.0-proposal #3920

v5.0.0-proposal #3920

khanayan123 commented Jan 2, 2024 •

edited

Loading

github-actions bot commented Jan 2, 2024 •

edited

Loading

codecov bot commented Jan 2, 2024 •

edited

Loading

pr-commenter bot commented Jan 2, 2024 •

edited

Loading

tlhunter Jan 9, 2024

Qard Jan 9, 2024

khanayan123 Jan 9, 2024

simon-id commented Jan 10, 2024

khanayan123 commented Jan 10, 2024

v5.0.0-proposal #3920

v5.0.0-proposal #3920

Conversation

khanayan123 commented Jan 2, 2024 • edited Loading

Breaking Changes

Features

Improvements

github-actions bot commented Jan 2, 2024 • edited Loading

Overall package size

Dependency sizes

codecov bot commented Jan 2, 2024 • edited Loading

Codecov Report

pr-commenter bot commented Jan 2, 2024 • edited Loading

Benchmarks

scenario:plugin-graphql-with-depth-on-max-18

tlhunter Jan 9, 2024

Choose a reason for hiding this comment

Qard Jan 9, 2024

Choose a reason for hiding this comment

khanayan123 Jan 9, 2024

Choose a reason for hiding this comment

simon-id commented Jan 10, 2024

khanayan123 commented Jan 10, 2024

khanayan123 commented Jan 2, 2024 •

edited

Loading

github-actions bot commented Jan 2, 2024 •

edited

Loading

codecov bot commented Jan 2, 2024 •

edited

Loading

pr-commenter bot commented Jan 2, 2024 •

edited

Loading