-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore header vulnerabilities in cors headers #3962
Conversation
Overall package sizeSelf size: 5.84 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3962 +/- ##
==========================================
+ Coverage 85.02% 86.04% +1.01%
==========================================
Files 238 232 -6
Lines 10192 9558 -634
Branches 33 33
==========================================
- Hits 8666 8224 -442
+ Misses 1526 1334 -192 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-15 14:29:22 Comparing candidate commit 809c08b in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
packages/dd-trace/src/appsec/iast/analyzers/header-injection-analyzer.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
What does this PR do?
Prevent creating header injection vulnerability when the source of the tainted string is a header and it's setting cors header.
Motivation
Prevent false positive detections in header injection vulnerabilities
Plugin Checklist
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!
APPSEC-50467