Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore header vulnerabilities in cors headers #3962

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jan 12, 2024

What does this PR do?

Prevent creating header injection vulnerability when the source of the tainted string is a header and it's setting cors header.

Motivation

Prevent false positive detections in header injection vulnerabilities

Plugin Checklist

  • Unit tests.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

APPSEC-50467

Copy link

github-actions bot commented Jan 12, 2024

Overall package size

Self size: 5.84 MB
Deduped: 61.49 MB
No deduping: 62.25 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.2 45.99 kB 709.38 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c132218) 85.02% compared to head (809c08b) 86.04%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3962      +/-   ##
==========================================
+ Coverage   85.02%   86.04%   +1.01%     
==========================================
  Files         238      232       -6     
  Lines       10192     9558     -634     
  Branches       33       33              
==========================================
- Hits         8666     8224     -442     
+ Misses       1526     1334     -192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 12, 2024

Benchmarks

Benchmark execution time: 2024-01-15 14:29:22

Comparing candidate commit 809c08b in PR branch ugaitz/fix-header-injection-cors with baseline commit c132218 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-101.046MB; -87.622MB] or [-10.826%; -9.388%]

@uurien uurien marked this pull request as ready for review January 15, 2024 12:07
@uurien uurien requested a review from a team as a code owner January 15, 2024 12:07
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@uurien uurien merged commit e678f30 into master Jan 15, 2024
109 of 110 checks passed
@uurien uurien deleted the ugaitz/fix-header-injection-cors branch January 15, 2024 15:54
simon-id pushed a commit that referenced this pull request Jan 18, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
szegedi pushed a commit that referenced this pull request Jan 23, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@szegedi szegedi mentioned this pull request Jan 24, 2024
szegedi pushed a commit that referenced this pull request Jan 24, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@szegedi szegedi mentioned this pull request Jan 24, 2024
szegedi pushed a commit that referenced this pull request Jan 24, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@szegedi szegedi mentioned this pull request Jan 24, 2024
szegedi pushed a commit that referenced this pull request Jan 24, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
szegedi pushed a commit that referenced this pull request Jan 24, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
szegedi pushed a commit that referenced this pull request Jan 24, 2024

---------

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants