V4.25.0 proposal #3990

szegedi · 2024-01-24T11:39:17Z

Bug Fixes

core: fixed empty strings being kept as valid values in config (fix empty strings being kept as valid values in config #3952)
appsec: fixed reuse of requestOptions object (fix: Do not reuse requestOptions object #3959)

Improvements

appsec: Appsec reporter now collects the x-amzn-trace-id header (Collect the X-Amzn-Trace-Id header #3984)
iast: Added support for weak randomness vulnerability (Add support for weak randomness vulnerability #3960)
iast: Ignore header vulnerabilities in cors headers (Ignore header vulnerabilities in cors headers #3962)
profiler: Added timelines env var, disabled timelines and CPU profiler on Windows (PROF-8935: Remove timelines experimental flag, disable timelines and CPU profiler on Windows #3969)
profiler: Disabled OOM monitoring by default on Windows ([profiling] Disable oom monitoring on windows #3974)

Build, CI, Tooling

ci-visibility: Added correlation ID to ITR requests ([ci-visibility] Add correlation ID to ITR requests #3980)
ci-visibility: Fixed telemetry in ci visibility ([ci-visibility] Fix telemetry in ci visibility #3964)
ci: Run profiler integration tests on macOS and Windows (PROF-8872: Run profiler integration tests on macOS and Windows #3945)
ci: fixed failing aerospike tests, and updated CI job names to be more specific (fix failing aerospike tests, and update CI job names to be more specific #3971)
testing: Better handling of multiple errors thrown in FakeAgent (PROF-8872: Better handling of multiple errors thrown in FakeAgent #3963)
added convenience script to run the system-tests (add convenience script to run the system-tests #3961)
updated import-in-the-middle to 1.7.3 (update import-in-the-middle to 1.7.3 #3975)
updated @datadog/native-appsec to v7.0.0 (Update @datadog/native-appsec to v7.0.0 #3973)

* update MIGRATING.md and README.md in preparation for v5 release

* fix empty strings being kept as valid values in config * set defaults as values

* fix: Do not reuse `requestOptions` object * rearrange RC http options * update tests --------- Co-authored-by: Tom Moor <tom.moor@gmail.com>

* Run the busy loop for longer, so there's better chance of capturing at least one sample in it. * Filter out samples taken in the root spans

* add convenience script to run the system-tests * fix child process stdio * catch subprocess error

) * Mocha doesn't like an array of errors being thrown, stash it into cause instead * Cause ain't reported by Mocha, put stacks into the timeout message

--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>

* Run profiler integration tests on both macOS and Windows * Exclude from Windows testing those tests aren't supposed to work on it. * Make createSandbox Windows-friendly * Increase profiler tests timeout as `yarn add` in sandbox creation takes a _lot_ of time. * Disable failing OOM integration tests on Windows * Only sync once * Move profiler integration test out of general integration test suite so it will not run twice on Linux

…fic (#3971)

…CPU profiler on Windows (#3969) * Make timeline setting non-experimental * Disallow CPU profiling on Windows * Disallow timeline view on Windows * Deduplicate test code, and also test for success on supported platforms * Fix a test

OOM monitoring currently does not work on Windows (process aborts before being able to send a last profile). This commit disables it by default on Windows.

* Weak randomnes vulnerability detection * Checking Math.random fn instead of target object * Include location check in full feature test

OOM monitoring option should be checked with checkOptionAllowed / oomMonitoringSupported.

github-actions · 2024-01-24T11:40:24Z

Overall package size

Self size: 5.85 MB
Deduped: 61.56 MB
No deduping: 62.32 MB

Dependency sizes

name	version	self size	total size
@datadog/native-iast-taint-tracking	1.6.4	16.43 MB	16.44 MB
@datadog/native-appsec	7.0.0	14.51 MB	14.52 MB
@datadog/pprof	5.0.0	9.59 MB	10.44 MB
protobufjs	7.2.5	2.77 MB	6.56 MB
@datadog/native-iast-rewriter	2.2.2	2.29 MB	2.37 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.4.1	780.32 kB	780.32 kB
import-in-the-middle	1.7.3	67.62 kB	731.01 kB
pprof-format	2.0.7	588.12 kB	588.12 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.4	93.4 kB	123.8 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ipaddr.js	2.1.0	60.23 kB	60.23 kB
ignore	5.2.4	51.22 kB	51.22 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
tlhunter-sorted-set	0.1.0	24.94 kB	24.94 kB
limiter	1.1.5	23.17 kB	23.17 kB
dc-polyfill	0.1.2	22.77 kB	22.77 kB
retry	0.13.1	18.85 kB	18.85 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
node-abort-controller	3.1.1	16.89 kB	16.89 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
jest-docblock	29.7.0	8.99 kB	12.76 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2024-01-24T11:40:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v4.x@7971eaa). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff           @@
##             v4.x    #3990   +/-   ##
=======================================
  Coverage        ?   84.99%           
=======================================
  Files           ?      239           
  Lines           ?    10234           
  Branches        ?       33           
=======================================
  Hits            ?     8698           
  Misses          ?     1536           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pr-commenter · 2024-01-24T11:50:18Z

Benchmarks

Benchmark execution time: 2024-01-24 11:50:12

Comparing candidate commit fe96f6b in PR branch v4.25.0-proposal with baseline commit 7971eaa in branch v4.x.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 775 metrics, 21 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

🟩 max_rss_usage [-144.178MB; -83.130MB] or [-15.156%; -8.739%]

scenario:plugin-q-with-tracer-16

🟩 instructions [-183.4M instructions; -121.1M instructions] or [-10.075%; -6.652%]

juan-fernandez

looks good from ci vis perspective

khanayan123 and others added 20 commits January 24, 2024 12:35

update MIGRATING.md and README.md in preparation for v5 release (#3918)

205528c

* update MIGRATING.md and README.md in preparation for v5 release

fix empty strings being kept as valid values in config (#3952)

f5edff1

* fix empty strings being kept as valid values in config * set defaults as values

fix readme for v5 preview (#3958)

cd1557f

fix: Do not reuse requestOptions object (#3959)

1050aaa

* fix: Do not reuse `requestOptions` object * rearrange RC http options * update tests --------- Co-authored-by: Tom Moor <tom.moor@gmail.com>

PROF-8850: Fix flaky code hotspots test (#3955)

052ba80

* Run the busy loop for longer, so there's better chance of capturing at least one sample in it. * Filter out samples taken in the root spans

add convenience script to run the system-tests (#3961)

f2c83e3

* add convenience script to run the system-tests * fix child process stdio * catch subprocess error

PROF-8872: Better handling of multiple errors thrown in FakeAgent (#3963

9d2f7dc

) * Mocha doesn't like an array of errors being thrown, stash it into cause instead * Cause ain't reported by Mocha, put stacks into the timeout message

Ignore header vulnerabilities in cors headers (#3962)

7a855c7

--------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>

[ci-visibility] Fix telemetry in ci visibility (#3964)

4681eb0

fix failing aerospike tests, and update CI job names to be more speci…

4a3ae62

…fic (#3971)

Update @datadog/native-appsec to v7.0.0 (#3973)

e8d1d36

Disable OOM monitoring by default on Windows (#3974)

de6051d

OOM monitoring currently does not work on Windows (process aborts before being able to send a last profile). This commit disables it by default on Windows.

Add support for weak randomness vulnerability (#3960)

08c1cbc

* Weak randomnes vulnerability detection * Checking Math.random fn instead of target object * Include location check in full feature test

update import-in-the-middle to 1.7.3 (#3975)

9721c05

Fix bad copy/paste (#3979)

24abefe

OOM monitoring option should be checked with checkOptionAllowed / oomMonitoringSupported.

Include x-amzn-trace-id header and a test (#3984)

9f03167

[ci-visibility] Add correlation ID to ITR requests (#3980)

11a5cf4

v4.25.0

fe96f6b

szegedi requested a review from a team as a code owner January 24, 2024 11:39

juan-fernandez approved these changes Jan 24, 2024

View reviewed changes

szegedi merged commit f027404 into v4.x Jan 24, 2024
115 checks passed

szegedi deleted the v4.25.0-proposal branch January 24, 2024 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V4.25.0 proposal #3990

V4.25.0 proposal #3990

szegedi commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

codecov bot commented Jan 24, 2024 •

edited

Loading

pr-commenter bot commented Jan 24, 2024

juan-fernandez left a comment

V4.25.0 proposal #3990

V4.25.0 proposal #3990

Conversation

szegedi commented Jan 24, 2024

Bug Fixes

Improvements

Build, CI, Tooling

github-actions bot commented Jan 24, 2024

Overall package size

Dependency sizes

codecov bot commented Jan 24, 2024 • edited Loading

Codecov Report

pr-commenter bot commented Jan 24, 2024

Benchmarks

scenario:plugin-graphql-with-depth-off-18

scenario:plugin-q-with-tracer-16

juan-fernandez left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 24, 2024 •

edited

Loading