APM > Connect logs and traces > .NET - Update supported logging libraries #11484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Depending if DataDog/dd-trace-dotnet#1663 gets merged before the next release, maybe we should mention that too?
Good call, can we sync on this tomorrow so I know what updates are needed for this PR? |
I think the updates will require a fair number of updates (new tabs, etc) so maybe I should do that in a new PR after this one is merged? |
4 tasks
zacharycmontoya
deleted the
zach.montoya/apm-dotnet-logs-injection-nlog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the version numbers for .NET logging libraries supported for logs injection:
Motivation
In the .NET Tracer, we added more error-handling scenarios for logs injection and this surfaced some gaps we had in our support matrix.
Preview
https://docs-staging.datadoghq.com/zach.montoya/apm-dotnet-logs-injection-nlog/tracing/connect_logs_and_traces/dotnet?tab=serilog
Additional Notes
The updated support for NLog will take effect in the next .NET Tracer official release, so this should not be merged until then.
Reviewer checklist