Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM > .NET > add new integrations and update logging #11623

Merged
merged 10 commits into from
Sep 10, 2021

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Sep 7, 2021

What does this PR do?

Adds new supported integrations, and updates the log injection supported libraries, and updates the log injection documentation to differentiate between logs injection and logs ingestion.

Motivation

We want to document the latest features in the .NET Tracer. Also the log injection page was somewhat confusing and misleading, in that it implies Manual logs injection is required if you want to write your logs in non-JSON. (Custom log rules are required, but that is unrelated to logs injection).

Preview

https://docs-staging.datadoghq.com/andrewlock/apm-dotnet/updates/tracing/setup_overview/compatibility_requirements/dotnet-core/
https://docs-staging.datadoghq.com/andrewlock/apm-dotnet/updates/tracing/setup_overview/compatibility_requirements/dotnet-framework/
https://docs-staging.datadoghq.com/andrewlock/apm-dotnet/updates/tracing/connect_logs_and_traces/dotnet

Additional Notes

This includes the changes from #11484


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@andrewlock andrewlock requested a review from a team as a code owner September 7, 2021 17:13
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Sep 7, 2021
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nits!

content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
content/en/tracing/connect_logs_and_traces/dotnet.md Outdated Show resolved Hide resolved
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Copy link
Contributor

@jaycdave88 jaycdave88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content wise - LGTM!

* Move GettingStarted content entirely to separate tabs
* Mention about auto instrumention requirement in ILogger
* Mention about enabling log scopes in ILogger
* Re-number automatic/manual to restart numbering (as each tab has a different number of steps)
Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on content

Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending this commit!

@alai97 alai97 merged commit e43a294 into master Sep 10, 2021
@alai97 alai97 deleted the andrewlock/apm-dotnet/updates branch September 10, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracing Content changed in the tracing folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants