-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APM > .NET > add new integrations and update logging #11623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar nits!
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content wise - LGTM!
* Move GettingStarted content entirely to separate tabs * Mention about auto instrumention requirement in ILogger * Mention about enabling log scopes in ILogger * Re-number automatic/manual to restart numbering (as each tab has a different number of steps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on content
Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending this commit!
What does this PR do?
Adds new supported integrations, and updates the log injection supported libraries, and updates the log injection documentation to differentiate between logs injection and logs ingestion.
Motivation
We want to document the latest features in the .NET Tracer. Also the log injection page was somewhat confusing and misleading, in that it implies Manual logs injection is required if you want to write your logs in non-JSON. (Custom log rules are required, but that is unrelated to logs injection).
Preview
https://docs-staging.datadoghq.com/andrewlock/apm-dotnet/updates/tracing/setup_overview/compatibility_requirements/dotnet-core/
https://docs-staging.datadoghq.com/andrewlock/apm-dotnet/updates/tracing/setup_overview/compatibility_requirements/dotnet-framework/
https://docs-staging.datadoghq.com/andrewlock/apm-dotnet/updates/tracing/connect_logs_and_traces/dotnet
Additional Notes
This includes the changes from #11484
Reviewer checklist