Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for uncompressed layers by default #1573

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Oct 22, 2024

What this PR does / why we need it:

discard_uncompressed_layers is enabled by default on GKE and EKS, causing all new customers of infrastructure vulnerabilities on these platforms to have a very high number of errors when generating SBOMs for container images.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@lebauce lebauce requested a review from a team as a code owner October 22, 2024 10:53
@lebauce lebauce changed the title Set support for uncompressed layers to true by default Enable support for uncompressed layers to true by default Oct 22, 2024
@lebauce lebauce changed the title Enable support for uncompressed layers to true by default Enable support for uncompressed layers by default Oct 22, 2024
@lebauce lebauce added chart/datadog This issue or pull request is related to the datadog chart bug Something isn't working labels Oct 22, 2024
@lebauce lebauce force-pushed the lebauce/uncompressed-layers-per-default branch from fa3a727 to 8b14e65 Compare October 22, 2024 10:57
@lebauce lebauce force-pushed the lebauce/uncompressed-layers-per-default branch from 3cd3989 to 207f66e Compare October 22, 2024 12:27
@lebauce
Copy link
Contributor Author

lebauce commented Oct 22, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 22, 2024

❌ MergeQueue

You are not allowed to use the merge queue towards main. User is not part of the authorized users or teams.
The authorized teams are: action-platform, agent-all, container-app, container-ecosystems, container-helm-chart-maintainers, container-integrations, container-t2, Synthetics, Documentation, Observability Pipelines, Telemetry and Analytics, Vector.
The authorized users are: cahillsf, clamoriniere, hkaj.

If you need support, contact us on Slack #devflow with those details!

@tbavelier
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 38m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 4b12bb1 into main Oct 23, 2024
27 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lebauce/uncompressed-layers-per-default branch October 23, 2024 12:49
jbartosik pushed a commit that referenced this pull request Oct 23, 2024
Co-authored-by: tbavelier <97530782+tbavelier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done tools/ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants