Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uncompressedlayerssupport only if containerImage is enabled #1585

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

tbavelier
Copy link
Member

What this PR does / why we need it:

In #1573 , datadog.sbom.containerImage.uncompressedLayersSupport was set to true to prevent errors for the SBOM feature on EKS, GKE, AKS where discard_uncompressed_layers is enabled by default. However, this feature requires CAP_SYS_ADMIN and mounts some directories that are not necessarily compatible with other distributions such as GKE Autopilot where the Daemonset can't be admitted anymore. This PR gates this default behind datadog.sbom.containerImage.enabled (false by default) to ensure we only add these modifications if and only if the user wants to use the SBOM container image feature.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@tbavelier tbavelier added bug Something isn't working chart/datadog This issue or pull request is related to the datadog chart labels Oct 24, 2024
@tbavelier tbavelier requested a review from a team as a code owner October 24, 2024 08:20
Co-authored-by: Celene <celene@datadoghq.com>
@tbavelier tbavelier merged commit 9a8a376 into main Oct 24, 2024
27 checks passed
@tbavelier tbavelier deleted the tbavelier/gate_uncompressed_behind_sbom branch October 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing latest helm chart (3.76.0) on GKE Autopilot
3 participants