Skip to content

Commit

Permalink
Adjust splunk_hec to distinguish decoded and raw bytes received (#1167)
Browse files Browse the repository at this point in the history
### What does this PR do?

Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry
from this blackhole matches the others in the project, measuring the raw/wire bytes
in `bytes_received`.
  • Loading branch information
blt authored Dec 17, 2024
1 parent 14c4c66 commit fdcd881
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## Changed
- The `bytes_received` metric in the HTTP blackhole now tracks wire bytes, the
former metric is preserved with `decoded_bytes_received`.
- The `bytes_received` metric in the HTTP and splunk_hec blackholes now tracks
wire bytes, the former metric is preserved with `decoded_bytes_received`.
- Base image is now bookworm, updated from bullseye.

## [0.25.1]
Expand Down
3 changes: 2 additions & 1 deletion lading/src/blackhole/splunk_hec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,12 @@ async fn srv(

let (parts, body) = req.into_parts();
let bytes = body.collect().await?.to_bytes();
counter!("bytes_received", &*labels).increment(bytes.len() as u64);

match crate::codec::decode(parts.headers.get(hyper::header::CONTENT_ENCODING), bytes) {
Err(response) => Ok(response),
Ok(body) => {
counter!("bytes_received", &*labels).increment(body.len() as u64);
counter!("decoded_bytes_received", &*labels).increment(body.len() as u64);

let mut okay = Response::default();
*okay.status_mut() = StatusCode::OK;
Expand Down

0 comments on commit fdcd881

Please sign in to comment.