Adjust how bytes_received is calculated in the HTTP blackhole
#1166
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts `bytes_received` to measure the bytes received over the wire before decoding. This allows lading to make assertions about the efficacy of compression by targets, matching the behavior of the other lading blackholes. We preserve the decoded metric by renaming it `decoded_bytes_received`. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
scottopell
approved these changes
Dec 17, 2024
Co-authored-by: Scott Opell <me@scottopell.com>
StephenWakely
approved these changes
Dec 17, 2024
Merge activity
|
blt
deleted the
blt/track_raw_bytes_received_in_blackholes_that_decompress
branch
blt
added a commit
that referenced
this pull request
Dec 17, 2024
Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry from this blackhole matches the others in the project, measuring the raw/wire bytes in `bytes_received`. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
added a commit
that referenced
this pull request
Dec 17, 2024
Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry from this blackhole matches the others in the project, measuring the raw/wire bytes in `bytes_received`. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
added a commit
that referenced
this pull request
Dec 17, 2024
Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry from this blackhole matches the others in the project, measuring the raw/wire bytes in `bytes_received`. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
added a commit
that referenced
this pull request
Dec 17, 2024
Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry from this blackhole matches the others in the project, measuring the raw/wire bytes in `bytes_received`. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
added a commit
that referenced
this pull request
Dec 17, 2024
### What does this PR do? Similar to #1166 this commit adds a `decoded_bytes_received` so that the telemetry from this blackhole matches the others in the project, measuring the raw/wire bytes in `bytes_received`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adjusts
bytes_receivedto measure the bytes received over the wirebefore decoding. This allows lading to make assertions about the efficacy of
compression by targets, matching the behavior of the other lading blackholes. We
preserve the decoded metric by renaming it
decoded_bytes_received.