Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read CPU percentage from cgroup data #1140

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Dec 11, 2024

What does this PR do?

This commit expands the cgroup sub-observer to inspect the CPU consumption of the target group, calculating a percentage utilization from this.

Related issues

Resolves SMPTNG-385
REF SMPTNG-109

@blt blt mentioned this pull request Dec 11, 2024
@blt blt added the no-changelog label Dec 11, 2024 — with Graphite App
@blt blt marked this pull request as ready for review December 11, 2024 01:59
@blt blt requested a review from a team as a code owner December 11, 2024 01:59
@blt blt changed the base branch from blt/correct_a_coercion_bug_in_capture_manager to graphite-base/1140 December 11, 2024 02:29
@blt blt force-pushed the graphite-base/1140 branch from ef5f4e1 to e86da2c Compare December 11, 2024 02:29
@blt blt force-pushed the blt/read_cpu_percentage_from_cgroup_data branch from 1dd90dc to c6d0771 Compare December 11, 2024 02:29
@blt blt changed the base branch from graphite-base/1140 to main December 11, 2024 02:29
@blt blt force-pushed the blt/read_cpu_percentage_from_cgroup_data branch from c6d0771 to 4a8ac54 Compare December 11, 2024 02:29
This commit expands the cgroup sub-observer to inspect the CPU consumption
of the target group, calculating a percentage utilization from this.

Resolves SMPTNG-385

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt force-pushed the blt/read_cpu_percentage_from_cgroup_data branch from 4a8ac54 to b5b4062 Compare December 11, 2024 19:55
})
})
.lock()
.expect("could not lock stats, poisoned by my constituents");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt merged commit 13f4115 into main Dec 11, 2024
19 checks passed
Copy link
Collaborator Author

blt commented Dec 11, 2024

Merge activity

  • Dec 11, 4:00 PM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants