Remove procfs CPU percentage #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 11, 2024
blt
force-pushed
the
blt/read_cpu_percentage_from_cgroup_data
branch
2 times, most recently
from
c6d0771 to
4a8ac54
Compare
blt
force-pushed
the
blt/remove_procfs_cpu_percentage
branch
from
d8f31f4 to
de4a638
Compare
GeorgeHahn
reviewed
Dec 11, 2024
| @@ -91,16 +91,9 @@ pub(crate) async fn poll(group_prefix: &Path, labels: &[(String, String)]) -> Re | |||
| let user_cpu = (delta_user as f64 / delta_time) / allowed_cores * 100.0; | |||
There was a problem hiding this comment.
There's a warning above that's cropping up from somewhere in this stack.
GeorgeHahn
approved these changes
Dec 11, 2024
blt
force-pushed
the
blt/read_cpu_percentage_from_cgroup_data
branch
from
4a8ac54 to
b5b4062
Compare
blt
force-pushed
the
blt/remove_procfs_cpu_percentage
branch
2 times, most recently
from
2ba3a8d to
8465ba7
Compare
blt
changed the base branch from
blt/read_cpu_percentage_from_cgroup_data
to
graphite-base/1141
This commit adjusts the CPU percentages that make it to the captures to be founded on cgroup data. This commit primarily removes code as a result. REF SMPTNG-385 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
graphite-base/1141
branch
from
4b426fc to
13f4115
Compare
blt
force-pushed
the
blt/remove_procfs_cpu_percentage
branch
from
8465ba7 to
0caea85
Compare
blt
force-pushed
the
blt/remove_procfs_cpu_percentage
branch
from
0caea85 to
01a08bb
Compare
Merge activity
|
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adjusts the CPU percentages that make it to the captures
to be founded on cgroup data. This commit primarily removes code as
a result.
Related issues
Resolves SMPTNG-385
REF SMPTNG-109