Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust how bytes_received is calculated in the HTTP blackhole #1166

Merged
merged 3 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## Changed
- The `bytes_received` metric in the HTTP blackhole now tracks raw bytes, the
blt marked this conversation as resolved.
Show resolved Hide resolved
former metric is preserved with `decoded_bytes_received`.

## [0.25.1]
## Removed
- Revert PR #1148
Expand Down
3 changes: 2 additions & 1 deletion lading/src/blackhole/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,12 @@ async fn srv(
let (parts, body) = req.into_parts();

let bytes = body.collect().await?.to_bytes();
counter!("bytes_received", &metric_labels).increment(bytes.len() as u64);

match crate::codec::decode(parts.headers.get(hyper::header::CONTENT_ENCODING), bytes) {
Err(response) => Ok(response),
Ok(body) => {
counter!("bytes_received", &metric_labels).increment(body.len() as u64);
counter!("decoded_bytes_received", &metric_labels).increment(body.len() as u64);

tokio::time::sleep(response_delay).await;

Expand Down
Loading