Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Enable DD_APPSEC_SCA_ENABLED env var test for nodejs #2372

Merged
merged 7 commits into from
May 7, 2024

Conversation

CarlesDD
Copy link
Contributor

Motivation

Enable DD_APPSEC_SCA_ENABLED config telemetry system test for NodeJS library

Changes

  • Test enabled in nodejs manifest
  • Java flavour assert for no propagation test

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@CarlesDD CarlesDD marked this pull request as ready for review May 6, 2024 08:21
@CarlesDD CarlesDD requested review from a team and Kyle-Verhoog as code owners May 6, 2024 08:21
@CarlesDD CarlesDD merged commit 80457e4 into main May 7, 2024
24 checks passed
@CarlesDD CarlesDD deleted the ccapell/sca-env-var-telemetry-nodejs branch May 7, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants