Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Enable DD_APPSEC_SCA_ENABLED env var test for nodejs #2372

Merged
merged 7 commits into from
May 7, 2024
+2 −2
Merged

[nodejs] Enable DD_APPSEC_SCA_ENABLED env var test for nodejs #2372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a497bc
Fix assert for nodejs in no propagtion test
CarlesDD Apr 22, 2024
f615b43
Enable APPSEC SCA env var test for nodejs
CarlesDD Apr 22, 2024
fe00b15
Merge branch 'main' into ccapell/sca-env-var-telemetry-nodejs
CarlesDD May 3, 2024
3a75f6a
Merge branch 'main' into ccapell/sca-env-var-telemetry-nodejs
CarlesDD May 6, 2024
9d8079b
Set version for Telemetry SCA env var test for nodejs
CarlesDD May 6, 2024
0484d0d
Set version for Telemetry SCA env var test for nodejs - previous one
CarlesDD May 6, 2024
9efecee
Revert "Set version for Telemetry SCA env var test for nodejs - previ…
CarlesDD May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ tests/:
Test_Defaults: v5.6.0
Test_Environment: v5.6.0
Test_TelemetryInstallSignature: v4.23.0
Test_TelemetrySCAEnvVar: missing_feature
Test_TelemetrySCAEnvVar: v5.13.0
test_trace_sampling.py:
Test_Trace_Sampling_Basic: missing_feature
Test_Trace_Sampling_Globs: missing_feature
Expand Down
2 changes: 1 addition & 1 deletion tests/parametric/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def test_telemetry_sca_enabled_not_propagated(self, library_env, test_agent, tes

DD_APPSEC_SCA_ENABLED = self.get_dd_appsec_sca_enabled_str(context.library)

if context.library == "java":
if context.library in ("java", "nodejs"):
cfg_appsec_enabled = configuration_by_name.get(DD_APPSEC_SCA_ENABLED)
assert cfg_appsec_enabled is not None, "Missing telemetry config item for '{}'".format(
DD_APPSEC_SCA_ENABLED
Expand Down