Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Khanayan123/enable nodejs consistency test #3144

Merged
merged 29 commits into from
Nov 8, 2024
Merged

Khanayan123/enable nodejs consistency test #3144

merged 29 commits into from
Nov 8, 2024

Conversation

khanayan123
Copy link
Contributor

@khanayan123 khanayan123 commented Sep 30, 2024 •
edited
Loading

Motivation

Enable config consistency tests for node.js

Changes

Enabled config consistency tests for node.js along with some changes to make tests follow spec

@khanayan123 khanayan123 mentioned this pull request Oct 2, 2024
Merged
@khanayan123 khanayan123 force-pushed the khanayan123/enable-nodejs-consistency-test branch from 35d2a2d to e27026a Compare October 22, 2024 01:37
@khanayan123 khanayan123 marked this pull request as ready for review October 22, 2024 01:39
@khanayan123 khanayan123 requested review from a team and mabdinur as code owners October 22, 2024 01:39
@khanayan123 khanayan123 requested review from mabdinur and mtoffl01 and removed request for mabdinur October 22, 2024 01:39
simon-id
simon-id reviewed Oct 22, 2024
View reviewed changes
manifests/nodejs.yml Outdated Show resolved Hide resolved
cbeauchesne
cbeauchesne requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are failures in the CI related to changes made in this PR. I set it back to draft, you can set it to normal once failure are fixed.

@cbeauchesne cbeauchesne marked this pull request as draft October 22, 2024 09:59
@khanayan123 khanayan123 marked this pull request as ready for review October 23, 2024 19:28
@khanayan123 khanayan123 marked this pull request as draft October 23, 2024 19:37
@khanayan123 khanayan123 marked this pull request as ready for review October 24, 2024 14:21
@khanayan123 khanayan123 marked this pull request as draft October 24, 2024 14:22
@khanayan123 khanayan123 force-pushed the khanayan123/enable-nodejs-consistency-test branch from b97be3f to 1fc437d Compare October 24, 2024 19:52
@khanayan123 khanayan123 marked this pull request as ready for review October 24, 2024 21:36
cbeauchesne
cbeauchesne requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still failure in CI on the activated tests.

@cbeauchesne cbeauchesne marked this pull request as draft October 25, 2024 09:38
@khanayan123 khanayan123 marked this pull request as ready for review October 28, 2024 14:08
@khanayan123 khanayan123 force-pushed the khanayan123/enable-nodejs-consistency-test branch from 3296f0a to e583597 Compare October 28, 2024 15:46
@khanayan123 khanayan123 marked this pull request as draft October 28, 2024 17:20
@khanayan123 khanayan123 marked this pull request as ready for review October 29, 2024 13:54
@khanayan123 khanayan123 force-pushed the khanayan123/enable-nodejs-consistency-test branch from 1480d96 to 2f03e70 Compare November 6, 2024 20:03
@khanayan123 khanayan123 requested review from a team as code owners November 6, 2024 20:03
cbeauchesne
cbeauchesne requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are failure related to the change.

@cbeauchesne
Copy link
Collaborator

I set back this PR to draft, to unstress my notifications stack 😄 . You can set it back to normal once it;s ready for review. If you need any help, please reach me on slack.

@cbeauchesne cbeauchesne marked this pull request as draft November 7, 2024 14:40
@khanayan123
Copy link
Contributor Author

I set back this PR to draft, to unstress my notifications stack 😄 . You can set it back to normal once it;s ready for review. If you need any help, please reach me on slack.

I think it was just test flakiness, after rerunning those tests are passing now

@khanayan123 khanayan123 marked this pull request as ready for review November 7, 2024 17:50
@khanayan123 khanayan123 merged commit 37a6e0e into main Nov 8, 2024
463 of 467 checks passed
@khanayan123 khanayan123 deleted the khanayan123/enable-nodejs-consistency-test branch November 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@mabdinur mabdinur Awaiting requested review from mabdinur mabdinur is a code owner

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

@simon-id simon-id Awaiting requested review from simon-id

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khanayan123 @cbeauchesne @simon-id @iunanua @robertomonteromiguel @raphaelgavache