Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Scrub more of exception replay snapshots + re-enable tests #3664

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

shurivich
Copy link
Contributor

Motivation

Exception replay tests were flaky due to runtime elements that vary depending on platform, version, and other factors. This PR fixes the issue by scrubbing out all runtime elements that are not related to our code.

Changes

  • Moved exception replay code from DebuggerCollector to ExceptionReplayCollector for improved test isolation.
  • Scrubbed all inner elements that start with ("jdk.", "org.", "java") for java and ("Microsoft", "System") for dotnet.
  • Re-enabled the exception replay tests.

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@shurivich shurivich self-assigned this Dec 12, 2024
@shurivich shurivich marked this pull request as ready for review December 15, 2024 12:40
@shurivich shurivich requested review from a team as code owners December 15, 2024 12:40
@shurivich shurivich merged commit 9b857f9 into main Dec 15, 2024
427 of 435 checks passed
@shurivich shurivich deleted the shurivich/enable_er branch December 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants