Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Scrub more of exception replay snapshots + re-enable tests #3664

Merged
merged 2 commits into from
Dec 15, 2024
Merged

[Debugger] Scrub more of exception replay snapshots + re-enable tests #3664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2ca94a
scrub exception replay
shurivich Dec 12, 2024
558dcc8
format
shurivich Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions docs/weblog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,29 +616,11 @@ Additionally both methods support the following query parameters to use the sdk
- `sdk_mail`: user's mail to be used in the sdk call.
- `sdk_user_exists`: `true` of `false` to indicate wether the current user exists and populate the corresponding tag.

### GET /debugger
These endpoints are used for the Dynamic Instrumentation tests.

#### GET /debugger/log
This endpoint will be used to validate the log probe.

#### GET /debugger/metric
This endpoint will be used to validate the metric probe.

#### GET /debugger/span
This endpoint will be used to validate the span probe.

#### GET /debugger/span-decoration
This endpoint will be used to validate the span decoration probe.

#### GET /debugger/pii
This endpoint will be used to validate Dynamic Instrumentation pii redaction feature.

#### GET /expression/*
These endpoints will be used to validate Dynamic Instrumentation expression language feature.
### GET /debugger/*
These endpoints are used for the `Dynamic Instrumentation` tests.

#### GET /exceptionreplay/*
These endpoints will be used to validate Dynamic Instrumentation exception replay feature.
These endpoints will be used for `Exception Replay` tests.

### GET /createextraservice
should rename the trace service, creating a "fake" service
Expand Down
305 changes: 5 additions & 300 deletions tests/debugger/approvals/exception_replay_inner_dotnet_snapshots_expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,7 @@
"throwable": {
"message": "Outer exception",
"type": "System.Exception",
"stacktrace": [
{
"function": "weblog.DebuggerController.ExceptionReplayInner",
"lineNumber": 0
},
{
"function": "Unknown.lambda_method<scrubbed>",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor+SyncActionResultExecutor.Execute",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<<InvokeActionMethodAsync>g__Logged|12_1>d.MoveNext",
"lineNumber": 0
}
]
"stacktrace": "Unknown.lambda_method<scrubbed>"
},
"locals": {
"@exception": {
Expand Down Expand Up @@ -120,8 +103,8 @@
},
"arguments": {
"this": {
"type": "DebuggerController",
"value": "DebuggerController"
"type": "ExceptionReplayController",
"value": "ExceptionReplayController"
}
}
}
Expand All @@ -131,288 +114,10 @@
"version": 1,
"location": {
"method": "ExceptionReplayInner",
"type": "weblog.DebuggerController"
"type": "weblog.ExceptionReplayController"
}
},
"stack": [
{
"function": "weblog.DebuggerController.ExceptionReplayInner",
"fileName": "/app/DebuggerController.cs",
"lineNumber": 154
},
{
"function": "Unknown.lambda_method<scrubbed>",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor+SyncActionResultExecutor.Execute",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<<InvokeActionMethodAsync>g__Logged|12_1>d.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Logged|12_1",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAwaitedAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Controller.OnActionExecutionAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResourceFilter",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResourceFilter",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<<InvokeAsync>g__Logged|17_1>d.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Mvc.Routing.ControllerRequestDelegateFactory+<>c__DisplayClass12_0.<CreateRequestDelegate>b__0",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Authentication.AuthenticationMiddleware+<Invoke>d__6.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Authorization.AuthorizationMiddleware+<Invoke>d__11.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Session.SessionMiddleware+<Invoke>d__8.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Session.SessionMiddleware.Invoke",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.HostFiltering.HostFilteringMiddleware.Invoke",
"lineNumber": 0
},
{
"function": "Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNetCore.BlockingMiddleware+<Invoke>d__5.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNetCore.BlockingMiddleware.Invoke",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol+<ProcessRequests>d__238`1.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol+<ProcessRequestsAsync>d__237`1.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequestsAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.HttpConnection+<ProcessRequestsAsync>d__12`1.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.HttpConnection.ProcessRequestsAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.KestrelConnection`1+<ExecuteAsync>d__8.MoveNext",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start",
"lineNumber": 0
},
{
"function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.KestrelConnection`1.ExecuteAsync",
"lineNumber": 0
},
{
"function": "Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.KestrelConnection`1.System.Threading.IThreadPoolWorkItem.Execute",
"lineNumber": 0
},
{
"function": "System.Threading.ThreadPoolWorkQueue.Dispatch",
"lineNumber": 0
},
{
"function": "System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart",
"lineNumber": 0
}
],
"stack": "Unknown.lambda_method<scrubbed>",
"id": "<scrubbed>",
"timestamp": "<scrubbed>",
"duration": "<scrubbed>",
Expand Down
Loading
Loading