Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Enable tests for automated login events v3 #3666

Open
wants to merge 14 commits into
base: malvarez/appsec-login-events-v3
Choose a base branch
from
Open

[nodejs] Enable tests for automated login events v3 #3666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
214a778
Initial version
manuel-alvarez-alvarez Nov 29, 2024
37705a5
Add signup and blocking support
manuel-alvarez-alvarez Dec 11, 2024
81a6697
Apply PR feedback
manuel-alvarez-alvarez Dec 12, 2024
60fcf14
Update nodejs.yml
simon-id Dec 12, 2024
55288f8
skip some stuff
simon-id Dec 12, 2024
0e31bf6
run CI on feature branch
simon-id Dec 12, 2024
bcbb560
Apply more PR feedback
manuel-alvarez-alvarez Dec 13, 2024
f6531ab
Merge branch 'malvarez/appsec-login-events-v3' into node_login_events_v3
simon-id Dec 13, 2024
36e360e
Apply suggestions from code review
simon-id Dec 13, 2024
692baed
Merge branch 'malvarez/appsec-login-events-v3' into node_login_events_v3
simon-id Dec 14, 2024
13cbff7
Merge branch 'malvarez/appsec-login-events-v3' into node_login_events_v3
simon-id Dec 16, 2024
8112e87
Merge branch 'malvarez/appsec-login-events-v3' into node_login_events_v3
simon-id Dec 16, 2024
729700d
Merge branch 'malvarez/appsec-login-events-v3' into node_login_events_v3
simon-id Dec 16, 2024
9798374
Update utils/scripts/load-binary.sh
simon-id Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,10 +493,10 @@ tests/:
Test_V2_Login_Events: irrelevant
Test_V2_Login_Events_Anon: irrelevant
Test_V2_Login_Events_RC: irrelevant
Test_V3_Login_Events: missing_feature
Test_V3_Login_Events_Anon: missing_feature
Test_V3_Login_Events_Blocking: missing_feature
Test_V3_Login_Events_RC: missing_feature
Test_V3_Login_Events: *ref_5_29_0
Test_V3_Login_Events_Anon: *ref_5_29_0
Test_V3_Login_Events_Blocking: *ref_5_29_0
Test_V3_Login_Events_RC: *ref_5_29_0
test_automated_user_and_session_tracking.py:
Test_Automated_Session_Blocking: missing_feature
Test_Automated_User_Blocking: missing_feature
Expand Down
6 changes: 4 additions & 2 deletions tests/appsec/test_automated_login_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,8 +1221,8 @@ def validate_iden(meta):


libs_without_user_id = []
libs_without_user_exist = []
libs_without_user_id_on_failure = []
libs_without_user_exist = ["nodejs"]
libs_without_user_id_on_failure = ["nodejs"]


@rfc("https://docs.google.com/document/d/1RT38U6dTTcB-8muiYV4-aVDCsT_XrliyakjtAPyjUpw")
Expand Down Expand Up @@ -1484,6 +1484,7 @@ def test_login_sdk_failure_basic(self):
def setup_signup_local(self):
self.r_success = weblog.post("/signup", data=login_data(context, NEW_USER, PASSWORD))

@missing_feature(context.library == "nodejs", reason="Signup events not implemented")
def test_signup_local(self):
assert self.r_success.status_code == 200
for _, trace, span in interfaces.library.get_spans(request=self.r_success):
Expand Down Expand Up @@ -1777,6 +1778,7 @@ def test_login_sdk_failure_local(self):
def setup_signup_local(self):
self.r_success = weblog.post("/signup", data=login_data(context, NEW_USER, PASSWORD))

@missing_feature(context.library == "nodejs", reason="Signup events not implemented")
def test_signup_local(self):
assert self.r_success.status_code == 200
for _, trace, span in interfaces.library.get_spans(request=self.r_success):
Expand Down
Loading